Paths

Table of Contentst

Differential D16256

[avalanche] don't use global g_avalanche in net_processing
ClosedPublic
Actions

Authored by PiRK on May 30 2024, 12:37.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc8fabc010fdc: [avalanche] don't use global g_avalanche in net_processing

Summary

This diff is split out of D16224.

Pass the avalanche processor as a const pointer in the PeerManagerImpl constructor.
In most unit tests we currently pass it nullptr, except in processor_tests. This preserves the current behavior.

Depends on D16255

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29179
Build 57894: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57893: arc lint + arc unit

Event Timeline

PiRK created this revision.May 30 2024, 12:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2024, 12:37

PiRK requested review of this revision.May 30 2024, 12:37

remove the now redundant assertion

PiRK added a child revision: D16257: [avalanche] remove unnecessary nullptr checks for g_avalanche.May 30 2024, 13:08

Fabien requested changes to this revision.May 30 2024, 13:18

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
8325	duplicated
8342	style nit: `[this, isStaker]`
src/net_processing.h
58	Can't be `const avalanche::Processor *const avalanche` ?

This revision now requires changes to proceed.May 30 2024, 13:18

Harbormaster completed remote builds in B29178: Diff 48044.May 30 2024, 13:30

Harbormaster completed remote builds in B29179: Diff 48045.May 30 2024, 13:35

PiRK added inline comments.May 30 2024, 13:37

src/net_processing.h
58	I don't think so. The peer manager calls non-const processor functions (such as `registerVotes`, for example)

review

I confirm that I cannot make the processor const here. It fails to compile.

PiRK added inline comments.May 30 2024, 15:28

src/net_processing.cpp
8325	assertion removed in parent diff. The callsites all check for m_avalanche before calling this function

Harbormaster completed remote builds in B29183: Diff 48054.May 30 2024, 15:50

Fabien accepted this revision.May 30 2024, 20:34

This revision is now accepted and ready to land.May 30 2024, 20:34

Closed by commit rABCc8fabc010fdc: [avalanche] don't use global g_avalanche in net_processing (authored by PiRK). · Explain WhyMay 31 2024, 06:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc8fabc010fdc: [avalanche] don't use global g_avalanche in net_processing.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

2 lines

7 lines

net_processing.h

12 lines

net_processing.cpp

126 lines

test/

denialofservice_tests.cpp

14 lines

util/

setup_common.cpp

6 lines

Diff 48045

src/avalanche/test/processor_tests.cpp

Loading...

src/init.cpp

Loading...

src/net_processing.h

Loading...

src/net_processing.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...