Another step in removing access to the g_avalanche global in Chainstate code.
Depends on D16266
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCf7b37e5b553d: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile…
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/node/blockstorage.h | ||
|---|---|---|
| 300 ↗ | (On Diff #48080) | What if avalanche is not enabled ? |
| src/node/blockstorage.h | ||
|---|---|---|
| 300 ↗ | (On Diff #48080) | At the moment there is no code path that can call this function with the avalanche processor not being initialized. So I thought it is good to demonstrate it by passing a reference, so that code readers don't need to wonder about it. |
Comment Actions
we can pass a pointer to ThreadImport in anticipation of not initializing the avalanche processor when avalanche is not needed (see review D16224)
| src/init.cpp | ||
|---|---|---|
| 2667 ↗ | (On Diff #48091) | Is the shutdown code checking that m_load_block is joined before deleting the avalanche pointer ? Just making sure we don't introduce shutdown crashes |
| src/init.cpp | ||
|---|---|---|
| 2667 ↗ | (On Diff #48091) | Yes. In Shutdown we call node.chainman->m_load_block.join() before reseting the avalanche pointer.? |