[avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport
ClosedPublic
Actions

Authored by PiRK on Jun 4 2024, 10:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Another step in removing access to the g_avalanche global in Chainstate code.

Depends on D16266

Test Plan

ninja all check-all

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29210
Build 57956: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-diff · build-clang
Build 57955: arc lint + arc unit

PiRK created this revision.Jun 4 2024, 10:11

PiRK requested review of this revision.Jun 4 2024, 10:11

Fabien requested changes to this revision.Jun 4 2024, 11:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/node/blockstorage.h
300 ↗	(On Diff #48080)	What if avalanche is not enabled ?

This revision now requires changes to proceed.Jun 4 2024, 11:49

PiRK requested review of this revision.Jun 4 2024, 14:12

PiRK added inline comments.

src/node/blockstorage.h
300 ↗	(On Diff #48080)	At the moment there is no code path that can call this function with the avalanche processor not being initialized. So I thought it is good to demonstrate it by passing a reference, so that code readers don't need to wonder about it.

we can pass a pointer to ThreadImport in anticipation of not initializing the avalanche processor when avalanche is not needed (see review D16224)

PiRK planned changes to this revision.Jun 4 2024, 14:59

pass a pointer to the processor in ThreadImport

src/init.cpp
2667	Is the shutdown code checking that m_load_block is joined before deleting the avalanche pointer ? Just making sure we don't introduce shutdown crashes