Page MenuHomePhabricator
Differential D16269

[avalanche] pass the processor to Chainstate::PreciousBlock
ClosedPublic
Actions

Authored by PiRK on Jun 4 2024, 10:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbce200942978: [avalanche] pass the processor to Chainstate::PreciousBlock
Summary

Another step in removing access to the g_avalanche global in Chainstate code.

Depends on D16268

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 4 2024, 10:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2024, 10:14
PiRK requested review of this revision.Jun 4 2024, 10:14
PiRK added a child revision: D16270: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock.
Harbormaster completed remote builds in B29202: Diff 48082.Jun 4 2024, 11:10
Fabien requested changes to this revision.Jun 4 2024, 11:55
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
1560 ↗(On Diff #48082)

See comments on the dependency diffs, the same applies here

This revision now requires changes to proceed.Jun 4 2024, 11:55
PiRK updated this revision to Diff 48090.Jun 4 2024, 14:55

make it possible to run the RPC when the processor is not initialized

Harbormaster completed remote builds in B29209: Diff 48090.Jun 4 2024, 15:12
Fabien accepted this revision.Jun 4 2024, 16:31
This revision is now accepted and ready to land.Jun 4 2024, 16:31
Closed by commit rABCbce200942978: [avalanche] pass the processor to Chainstate::PreciousBlock (authored by PiRK). · Explain WhyJun 5 2024, 08:35
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbce200942978: [avalanche] pass the processor to Chainstate::PreciousBlock.

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
3 lines
6 lines

Diff 48109

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...