Differential D16389

validation: followups for de-duplication of packages
ClosedPublic
Actions

Authored by Fabien on Jun 28 2024, 20:47.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8dded22b93ac: validation: followups for de-duplication of packages

Summary

- Add a test for packages with a mix of duplicate/different witness/new parents
- Fix issue with not notifying CValidationInterface when there's a partial submission due to fail-fast

This completes backport of core#23804.
For previous diffs, see D12913.

The test has been adapted and renamed to match our codebase.

Depends on D16387.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR23804

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29415
Build 58366: Build Diff	lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-diff · build-clang · build-debug
Build 58365: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 28 2024, 20:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2024, 20:47

Fabien requested review of this revision.Jun 28 2024, 20:47

teamcity edited the summary of this revision. (Show Details)Jun 28 2024, 20:47

Harbormaster completed remote builds in B29415: Diff 48415.Jun 28 2024, 21:04

Fabien added a child revision: D16390: add RPC (-regtest only) for testing package policy.Jun 28 2024, 21:34

PiRK accepted this revision.Jun 29 2024, 16:38

This revision is now accepted and ready to land.Jun 29 2024, 16:38

Closed by commit rABC8dded22b93ac: validation: followups for de-duplication of packages (authored by glozow <gloriajzhao@gmail.com>, committed by Fabien). · Explain WhyJul 1 2024, 20:07

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8dded22b93ac: validation: followups for de-duplication of packages.

Revision Contents
Changeset List

Path

Size

src/

policy/

2 lines

test/

txpackage_tests.cpp

79 lines

3 lines

18 lines

Diff 48415

src/policy/packages.h

Loading...

src/test/txpackage_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...