Differential D16396

[validation] return effective feerate from mempool validation
ClosedPublic
Actions

Authored by Fabien on Mon, Jul 1, 21:04.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC763c2151032f: [validation] return effective feerate from mempool validation

Summary

Partial backport of core#26646:
https://github.com/bitcoin/bitcoin/pull/26646/commits/1605886380e4d3ff2e1236739fb800fa07322c49

This includes some code from https://github.com/bitcoin/bitcoin/pull/24152/commits/51edcffa0e156dba06191a8d5c636ba01fa5b65f
that was skipped during the backport of core#24152 because the test case was segwit related.
Some of the code was later reintroduced to create a non-segwit test for checking tx deduplication, and we need to add back
the relevant skipped changes to check the correct behavior here: if parent2 is not 0-fee, then it's valid according to the
mempool policy and so the package feerate is not computed (all txs being individually compliant, there is no reason to
check the package feerate).

Depends on D16395.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Jul 1, 21:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jul 1, 21:04

Fabien requested review of this revision.Mon, Jul 1, 21:04

teamcity edited the summary of this revision. (Show Details)Mon, Jul 1, 21:04

Fabien added a child revision: D16397: [validation] return txids of other transactions whose fees were used.Mon, Jul 1, 21:05

Rebase

roqqit accepted this revision.Mon, Jul 1, 22:03

This revision is now accepted and ready to land.Mon, Jul 1, 22:03

Harbormaster completed remote builds in B29424: Diff 48430.Mon, Jul 1, 22:17

Harbormaster completed remote builds in B29430: Diff 48436.Mon, Jul 1, 23:16

Fabien edited the summary of this revision. (Show Details)Tue, Jul 2, 07:07

Closed by commit rABC763c2151032f: [validation] return effective feerate from mempool validation (authored by glozow <gloriajzhao@gmail.com>, committed by Fabien). · Explain WhyTue, Jul 2, 07:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC763c2151032f: [validation] return effective feerate from mempool validation.

Revision Contents
Changeset List

Path

Size

src/

test/

txpackage_tests.cpp

59 lines

27 lines

55 lines

test/

functional/

rpc_packages.py

9 lines

Diff 48445

src/test/txpackage_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

test/functional/rpc_packages.py

Loading...