net_processing: move avalanche related args to PeerManager::Options
ClosedPublic
Actions

Authored by PiRK on Jul 12 2024, 10:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC020c3c10290b: net_processing: move avalanche related args to PeerManager::Options

Summary

This removes the PeerManager dependency on gArgs.

Non-backport follow-up to D16455

Depends on D16456

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr27499

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29541
Build 58617: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 58616: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 12 2024, 10:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2024, 10:56

PiRK requested review of this revision.Jul 12 2024, 10:56

PiRK retitled this revision from net_processing: move related args to PeerManager::Options to net_processing: move avalanche related args to PeerManager::Options.Jul 12 2024, 10:57

Fabien accepted this revision.Jul 12 2024, 11:36

This revision is now accepted and ready to land.Jul 12 2024, 11:36

Harbormaster completed remote builds in B29541: Diff 48605.Jul 12 2024, 12:07

Closed by commit rABC020c3c10290b: net_processing: move avalanche related args to PeerManager::Options (authored by PiRK). · Explain WhyJul 12 2024, 14:30

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC020c3c10290b: net_processing: move avalanche related args to PeerManager::Options.