Page MenuHomePhabricator

Use a single round of SHA256 ont he CHECKDATASIG message.
ClosedPublic

Authored by deadalnix on Aug 14 2018, 20:10.

Details

Summary

As per suggestion in the spec review.

Test Plan

Updated test cases.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Aug 14 2018, 20:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2018, 20:10
jasonbcox accepted this revision.Aug 14 2018, 20:24
jasonbcox added a subscriber: jasonbcox.

Looks fine to me. Make sure tests pass in TeamCity first.

This revision is now accepted and ready to land.Aug 14 2018, 20:24
awemany added a subscriber: awemany.Aug 14 2018, 20:34

As the author of the previous differential D1652, this looks good to me. Test vectors seem to be the same (I just did a diff of the diffs, it is empty regarding the test vectors) and the code as far as I can see is equivalent.

However, one nit, though I don't know what ABC's code policy is right now: I called the message hash 'msghash' in the opcode implementation after Andrew Stone (theZerg) commented that this (or similar) is a more apt name. I think the same applies here.

Mengerian accepted this revision.Aug 14 2018, 20:46
Mengerian added a subscriber: Mengerian.

Looks good to me.

This revision was automatically updated to reflect the committed changes.