Use a single round of SHA256 ont he CHECKDATASIG message.
ClosedPublic
Actions

Authored by deadalnix on Aug 14 2018, 20:10.

Details

Reviewers

jasonbcox
Mengerian

Group Reviewers

Restricted Project

Commits

rSTAGING497a1b485ba9: Use a single round of SHA256 ont he CHECKDATASIG message.
rABC497a1b485ba9: Use a single round of SHA256 ont he CHECKDATASIG message.

Summary

As per suggestion in the spec review.

Test Plan

Updated test cases.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

simplehashdatasig

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3081
Build 4249: Bitcoin ABC Buildbot (legacy)
Build 4248: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 14 2018, 20:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2018, 20:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix mentioned this in D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.Aug 14 2018, 20:15

Looks fine to me. Make sure tests pass in TeamCity first.

This revision is now accepted and ready to land.Aug 14 2018, 20:24

As the author of the previous differential D1652, this looks good to me. Test vectors seem to be the same (I just did a diff of the diffs, it is empty regarding the test vectors) and the code as far as I can see is equivalent.

However, one nit, though I don't know what ABC's code policy is right now: I called the message hash 'msghash' in the opcode implementation after Andrew Stone (theZerg) commented that this (or similar) is a more apt name. I think the same applies here.