Page MenuHomePhabricator
Differential D1661

Seperated CDiskBlockIndex class from chain.h into its own .h file and updated other .cpp and .h file dependencies.
AbandonedPublic
Actions

Authored by nakihito on Aug 20 2018, 03:47.

Details

Reviewers
jasonbcox
deadalnix
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Continues T380, dependent on D1660. Removed CDiskBlockIndex from chain.h into diskblockindex.h and updated other file dependencies.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeperatingDiskBlockIndexClass
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3441
Build 4958: Bitcoin ABC Buildbot (legacy)
Build 4957: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 20 2018, 03:47
Owners added a reviewer: Restricted Owners Package.Aug 20 2018, 03:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2018, 03:47
teamcity added a subscriber: teamcity.Aug 20 2018, 03:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3095: Diff 4604!Aug 20 2018, 04:23
teamcity added a comment.Aug 20 2018, 04:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox requested changes to this revision.Aug 20 2018, 21:53
jasonbcox added inline comments.
src/diskblockindex.h
13 ↗(On Diff #4604)

Is this line necessary?

15 ↗(On Diff #4604)

This should be a doc-style comment, rather than one line, like:

/**
 * blah
 */
This revision now requires changes to proceed.Aug 20 2018, 21:53
teamcity added a comment.Aug 20 2018, 23:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 20 2018, 23:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3095: Diff 4604.Aug 20 2018, 23:47
nakihito added a comment.Aug 28 2018, 02:13

Work after this patch may require someone to go through some various .h files and untangle some include webs. As is, it compiles and runs through the tests fine on my computer. Update will be up after D1660's.

src/diskblockindex.h
13 ↗(On Diff #4604)

No, you're correct. I have already fixed it.

nakihito updated this revision to Diff 4713.Aug 28 2018, 03:22

Fixed some formatting errors and removed an unnecessary forward declaration.

teamcity added a comment.Aug 28 2018, 03:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 28 2018, 04:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3168: Diff 4713.Aug 28 2018, 04:01
jasonbcox accepted this revision.Sep 4 2018, 18:01
This revision is now accepted and ready to land.Sep 4 2018, 18:01
nakihito updated this revision to Diff 5173.Sep 29 2018, 08:08

Untangled a few more include trees and seperated more CChain member function implementation into chain.cpp.

teamcity added a comment.Sep 29 2018, 08:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 29 2018, 08:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3441: Diff 5173.Sep 29 2018, 08:26
jasonbcox requested changes to this revision.Nov 10 2018, 01:07

Needs to be rebased

This revision now requires changes to proceed.Nov 10 2018, 01:07
nakihito abandoned this revision.Feb 4 2019, 22:42

Revision Contents
Changeset List

PathSize
src/
rpc/
1 line
1 line
1 line
3 lines
1 line

Diff 5173

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/validation.h

Loading...
View Options

src/versionbits.h

Loading...
View Options

src/versionbits.cpp

Loading...