Page MenuHomePhabricator

Seperated CDiskBlockIndex class from chain.h into its own .h file and updated other .cpp and .h file dependencies.
AbandonedPublic

Authored by nakihito on Aug 20 2018, 03:47.

Details

Reviewers
jasonbcox
deadalnix
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Continues T380, dependent on D1660. Removed CDiskBlockIndex from chain.h into diskblockindex.h and updated other file dependencies.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeperatingDiskBlockIndexClass
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/diskblockindex.h:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 3095
Build 4277: Bitcoin ABC Buildbot (legacy)
Build 4276: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 20 2018, 03:47
jasonbcox requested changes to this revision.Aug 20 2018, 21:53
jasonbcox added inline comments.
src/diskblockindex.h
13

Is this line necessary?

15

This should be a doc-style comment, rather than one line, like:

/**
 * blah
 */
This revision now requires changes to proceed.Aug 20 2018, 21:53

Work after this patch may require someone to go through some various .h files and untangle some include webs. As is, it compiles and runs through the tests fine on my computer. Update will be up after D1660's.

src/diskblockindex.h
13

No, you're correct. I have already fixed it.

Fixed some formatting errors and removed an unnecessary forward declaration.

This revision is now accepted and ready to land.Sep 4 2018, 18:01

Untangled a few more include trees and seperated more CChain member function implementation into chain.cpp.

jasonbcox requested changes to this revision.Nov 10 2018, 01:07

Needs to be rebased

This revision now requires changes to proceed.Nov 10 2018, 01:07