Paths

Table of Contentst

Differential D16650

[avalanche] Reject transactions that conflict with a finalized one
ClosedPublic
Actions

Authored by Fabien on Aug 15 2024, 14:43.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4f410b8b7e06: [avalanche] Reject transactions that conflict with a finalized one

Summary

Treat these transaction separately from "regular" conflicting transactions, because they are plain invalid and don't need to be stored in the conflict pool.

After this diff we have 2 kind of conflicting txs:

conflicting with a non finalized transaction: at this stage the node has no idea which transaction is legit and it needs to be reconciled via avalanche (in a later diff)
conflicting with a finalized transaction: at this stage the node knows that this transaction is not the selected one and it should be treated as invalid.

The avalanche reconsiderable status could be later used to vote on transactions for other reason, e.g. for transactions that spend a proof coin.

Depends on D16649.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_reconsiderable

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30010
Build 59554: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 59553: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 15 2024, 14:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2024, 14:43

Fabien requested review of this revision.Aug 15 2024, 14:43

Harbormaster completed remote builds in B29995: Diff 49232.Aug 15 2024, 15:44

bytesofman added a subscriber: bytesofman.Aug 15 2024, 17:23

bytesofman added inline comments.

src/consensus/validation.h
49 ↗	(On Diff #49232)	what else could this include in addition to txs conflicting with another mempool tx?

Fabien added inline comments.Aug 15 2024, 18:36

src/consensus/validation.h
49 ↗	(On Diff #49232)	For now nothing else but we can imagine fees for example, or deployment of some new features with no consensus change (not planning to do so but imagine enforcing schnorr signatures only for example)

Fabien added inline comments.Aug 15 2024, 18:45

src/consensus/validation.h
49 ↗	(On Diff #49232)	Oh and also reject the txs that spend coins from an avalanche proof

bytesofman added inline comments.Aug 15 2024, 22:25

src/consensus/validation.h
49 ↗	(On Diff #49232)	would this be the sort of thing that could be appropriate to include in comments? seems like there is no way for a developer without your individual insight here to know what this bucket would be, at least not without consulting this diff

roqqit added a subscriber: roqqit.Aug 15 2024, 22:48

roqqit added inline comments.

src/consensus/validation.h
49 ↗	(On Diff #49232)	I think the right way to do this is document these examples in the summary so they will appear as part of the commit. No need to include speculative features in code/comments. Relatedly, the distinction in the summary between "regular" conflicts, plain invalid, and policy failures (maybe reconsiderable?) is not clear. It would help to describe the interplay between TX_CONFLICT and TX_AVALANCHE_RECONSIDERABLE

Fabien edited the summary of this revision. (Show Details)Aug 16 2024, 08:45

Fix a typo and update the summary to better explain the rationale

Harbormaster completed remote builds in B30008: Diff 49250.Aug 16 2024, 09:06

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-08-16T08:57:17.457000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20240816_085517/abc_p2p_avalanche_transaction_voting_15
2024-08-16T08:57:19.262000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-08-16T08:57:19.316000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-08-16T08:57:21.559000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-08-16T08:57:22.242000Z TestFramework (INFO): Check the votes on unknown transactions
2024-08-16T08:57:22.296000Z TestFramework (INFO): Check the votes on invalid transactions
2024-08-16T08:57:22.401000Z TestFramework (INFO): Check the votes on orphan transactions
2024-08-16T08:57:22.507000Z TestFramework (INFO): Check the votes on conflicting transactions
2024-08-16T08:57:22.667000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-08-16T08:57:29.095000Z TestFramework (INFO): Check the node rejects txs that conflict with a finalized tx
2024-08-16T08:57:29.148000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 224, in run_test
    node.gettransactionpool(another_conflicting_tx["txid"])["pool"], "none"
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 180, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2024-08-16T08:57:29.199000Z TestFramework (INFO): Stopping nodes
2024-08-16T08:57:29.500000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20240816_085517/abc_p2p_avalanche_transaction_voting_15
2024-08-16T08:57:29.500000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20240816_085517/abc_p2p_avalanche_transaction_voting_15/test_framework.log
2024-08-16T08:57:29.501000Z TestFramework (ERROR): 
2024-08-16T08:57:29.501000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20240816_085517/abc_p2p_avalanche_transaction_voting_15' to consolidate all logs
2024-08-16T08:57:29.501000Z TestFramework (ERROR): 
2024-08-16T08:57:29.501000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-08-16T08:57:29.501000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-08-16T08:57:29.501000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-08-16T09:02:57.222000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20240816_090159/abc_p2p_avalanche_transaction_voting_15
2024-08-16T09:02:57.884000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-08-16T09:02:57.938000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-08-16T09:02:59.975000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-08-16T09:03:00.604000Z TestFramework (INFO): Check the votes on unknown transactions
2024-08-16T09:03:00.658000Z TestFramework (INFO): Check the votes on invalid transactions
2024-08-16T09:03:00.763000Z TestFramework (INFO): Check the votes on orphan transactions
2024-08-16T09:03:00.869000Z TestFramework (INFO): Check the votes on conflicting transactions
2024-08-16T09:03:01.026000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-08-16T09:03:07.103000Z TestFramework (INFO): Check the node rejects txs that conflict with a finalized tx
2024-08-16T09:03:07.155000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 224, in run_test
    node.gettransactionpool(another_conflicting_tx["txid"])["pool"], "none"
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 180, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2024-08-16T09:03:07.206000Z TestFramework (INFO): Stopping nodes
2024-08-16T09:03:07.357000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20240816_090159/abc_p2p_avalanche_transaction_voting_15
2024-08-16T09:03:07.357000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20240816_090159/abc_p2p_avalanche_transaction_voting_15/test_framework.log
2024-08-16T09:03:07.357000Z TestFramework (ERROR): 
2024-08-16T09:03:07.357000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20240816_090159/abc_p2p_avalanche_transaction_voting_15' to consolidate all logs
2024-08-16T09:03:07.357000Z TestFramework (ERROR): 
2024-08-16T09:03:07.357000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-08-16T09:03:07.357000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-08-16T09:03:07.357000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-08-16T08:58:45.405000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_085723/abc_p2p_avalanche_transaction_voting_15
2024-08-16T08:58:46.693000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-08-16T08:58:46.747000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-08-16T08:58:48.842000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-08-16T08:58:49.585000Z TestFramework (INFO): Check the votes on unknown transactions
2024-08-16T08:58:49.641000Z TestFramework (INFO): Check the votes on invalid transactions
2024-08-16T08:58:49.747000Z TestFramework (INFO): Check the votes on orphan transactions
2024-08-16T08:58:49.857000Z TestFramework (INFO): Check the votes on conflicting transactions
2024-08-16T08:58:50.022000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-08-16T08:58:56.852000Z TestFramework (INFO): Check the node rejects txs that conflict with a finalized tx
2024-08-16T08:58:56.904000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 224, in run_test
    node.gettransactionpool(another_conflicting_tx["txid"])["pool"], "none"
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 180, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2024-08-16T08:58:56.955000Z TestFramework (INFO): Stopping nodes
2024-08-16T08:58:57.306000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_085723/abc_p2p_avalanche_transaction_voting_15
2024-08-16T08:58:57.306000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_085723/abc_p2p_avalanche_transaction_voting_15/test_framework.log
2024-08-16T08:58:57.307000Z TestFramework (ERROR): 
2024-08-16T08:58:57.307000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_085723/abc_p2p_avalanche_transaction_voting_15' to consolidate all logs
2024-08-16T08:58:57.307000Z TestFramework (ERROR): 
2024-08-16T08:58:57.307000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-08-16T08:58:57.307000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-08-16T08:58:57.307000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-08-16T09:03:27.130000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_090212/abc_p2p_avalanche_transaction_voting_15
2024-08-16T09:03:27.793000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-08-16T09:03:27.848000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-08-16T09:03:29.978000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-08-16T09:03:30.616000Z TestFramework (INFO): Check the votes on unknown transactions
2024-08-16T09:03:30.671000Z TestFramework (INFO): Check the votes on invalid transactions
2024-08-16T09:03:30.776000Z TestFramework (INFO): Check the votes on orphan transactions
2024-08-16T09:03:30.881000Z TestFramework (INFO): Check the votes on conflicting transactions
2024-08-16T09:03:31.038000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-08-16T09:03:37.124000Z TestFramework (INFO): Check the node rejects txs that conflict with a finalized tx
2024-08-16T09:03:37.176000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 224, in run_test
    node.gettransactionpool(another_conflicting_tx["txid"])["pool"], "none"
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 180, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2024-08-16T09:03:37.227000Z TestFramework (INFO): Stopping nodes
2024-08-16T09:03:37.379000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_090212/abc_p2p_avalanche_transaction_voting_15
2024-08-16T09:03:37.379000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_090212/abc_p2p_avalanche_transaction_voting_15/test_framework.log
2024-08-16T09:03:37.379000Z TestFramework (ERROR): 
2024-08-16T09:03:37.379000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20240816_090212/abc_p2p_avalanche_transaction_voting_15' to consolidate all logs
2024-08-16T09:03:37.379000Z TestFramework (ERROR): 
2024-08-16T09:03:37.379000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-08-16T09:03:37.379000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-08-16T09:03:37.379000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py

Rebase and rename gettransactionpool -> gettransactionstatus

Harbormaster completed remote builds in B30010: Diff 49254.Aug 16 2024, 10:51

Looks good.
As discussed above, there is some ambiguity about TX_AVALANCHE_RECONSIDERABLE currently only being used for non-finalized conflicting txs (tx added to the TxConflicting pool). The pool will need to be renamed if/when we start adding other type of transactions to it, but that can be done if/when needed.

This revision is now accepted and ready to land.Aug 19 2024, 07:33

Closed by commit rABC4f410b8b7e06: [avalanche] Reject transactions that conflict with a finalized one (authored by Fabien). · Explain WhyAug 30 2024, 19:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4f410b8b7e06: [avalanche] Reject transactions that conflict with a finalized one.