Page MenuHomePhabricator
Differential D1666

Move VerifySignature to BaseSignatureChecker and use it for OP_CHECKDATASIG
ClosedPublic
Actions

Authored by deadalnix on Aug 21 2018, 21:05.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa5cb260806c6: Move VerifySignature to BaseSignatureChecker and use it for OP_CHECKDATASIG
rABCa5cb260806c6: Move VerifySignature to BaseSignatureChecker and use it for OP_CHECKDATASIG
Summary

This ensure that we also benefit from signature caching facilities provided by CachingTransactionSignatureChecker.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 21 2018, 21:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2018, 21:05
teamcity added a subscriber: teamcity.Aug 21 2018, 21:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 21 2018, 21:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3103: Diff 4617.Aug 21 2018, 21:43
jasonbcox accepted this revision.Aug 22 2018, 16:47
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/script/interpreter.h
69 ↗(On Diff #4617)

Reword it to explain why final is applied to these functions, otherwise the comment is redundant.

This revision is now accepted and ready to land.Aug 22 2018, 16:47
Closed by commit rABCa5cb260806c6: Move VerifySignature to BaseSignatureChecker and use it for OP_CHECKDATASIG (authored by deadalnix). · Explain WhyAug 23 2018, 16:54
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
script/
18 lines
11 lines

Diff 4620

View Options

src/script/interpreter.h

Loading...
View Options

src/script/interpreter.cpp

Loading...