Page MenuHomePhabricator

Move VerifySignature to BaseSignatureChecker and use it for OP_CHECKDATASIG
ClosedPublic

Authored by deadalnix on Aug 21 2018, 21:05.

Details

Summary

This ensure that we also benefit from signature caching facilities provided by CachingTransactionSignatureChecker.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/script/interpreter.h
69 ↗(On Diff #4617)

Reword it to explain why final is applied to these functions, otherwise the comment is redundant.

This revision is now accepted and ready to land.Aug 22 2018, 16:47
This revision was automatically updated to reflect the committed changes.