Page MenuHomePhabricator
Differential D16728

Compute the real-time hash target for the next block
AcceptedPublic
Actions

Authored by Fabien on Fri, Sep 6, 13:21.

Details

Reviewers
PiRK
roqqit
Group Reviewers
Restricted Project
Summary

Given some input parameters, compute the next minimum hash for a block to be avalanche accepted.
Only the computation is part of this diff.

Inspired by the research from https://ledger.pitt.edu/ojs/ledger/article/download/195/187/1008.

Test Plan
ninja check

Diff Detail

Event Timeline

Fabien created this revision.Fri, Sep 6, 13:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 6, 13:21
Fabien requested review of this revision.Fri, Sep 6, 13:21
Fabien edited the summary of this revision. (Show Details)Fri, Sep 6, 13:25
Harbormaster completed remote builds in B30206: Diff 49530.Fri, Sep 6, 13:43
Fabien added a child revision: D16729: Reject blocks that violate the real time target policy.Fri, Sep 6, 14:00
PiRK accepted this revision.Fri, Sep 6, 15:13
This revision is now accepted and ready to land.Fri, Sep 6, 15:13
roqqit accepted this revision.Fri, Sep 6, 16:37
Fabien planned changes to this revision.Mon, Sep 9, 07:19

Got offline feedback that deserves looking at a design update

Fabien updated this revision to Diff 49590.Wed, Sep 11, 14:21

Update the algorithm

This revision is now accepted and ready to land.Wed, Sep 11, 14:21
Fabien updated this revision to Diff 49591.Wed, Sep 11, 14:22

Typo

Harbormaster completed remote builds in B30253: Diff 49590.Wed, Sep 11, 14:48
Harbormaster completed remote builds in B30254: Diff 49591.Wed, Sep 11, 14:59
Fabien updated this revision to Diff 49597.Wed, Sep 11, 19:40

Improve comment on the windows selection

Harbormaster completed remote builds in B30259: Diff 49597.Wed, Sep 11, 19:55
Fabien updated this revision to Diff 49598.Wed, Sep 11, 19:57

EDA -> DAA

Harbormaster completed remote builds in B30260: Diff 49598.Wed, Sep 11, 20:20
roqqit requested changes to this revision.Wed, Sep 11, 21:03
roqqit added inline comments.
src/policy/block/rtt.cpp
36 ↗(On Diff #49598)

nit: this can be explicitly static also

src/test/rtt_tests.cpp
35–37 ↗(On Diff #49598)

Make this check more comprehensive

This revision now requires changes to proceed.Wed, Sep 11, 21:03
bytesofman added a subscriber: bytesofman.Wed, Sep 11, 23:26
bytesofman added inline comments.
src/policy/block/rtt.cpp
23 ↗(On Diff #49598)

i think either these formulae or this formula

33 ↗(On Diff #49598)
Fabien updated this revision to Diff 49606.Thu, Sep 12, 07:24

Feedback + remove the 18th block in the test, this is confusing for no reason as block[0] is the previous block as per the GetNextRTTWorkRequired call.

Harbormaster completed remote builds in B30267: Diff 49606.Thu, Sep 12, 07:40
PiRK accepted this revision.Thu, Sep 12, 09:12
PiRK added inline comments.
src/test/rtt_tests.cpp
35 ↗(On Diff #49606)
Fabien updated this revision to Diff 49609.Thu, Sep 12, 14:30

Fix typo

Harbormaster completed remote builds in B30270: Diff 49609.Thu, Sep 12, 14:45
roqqit accepted this revision.Thu, Sep 12, 15:38
This revision is now accepted and ready to land.Thu, Sep 12, 15:38

Revision Contents
Changeset List

PathSize
src/
2 lines
policy/
block/
24 lines
106 lines
test/
1 line
273 lines

Diff 49609

View Options

src/CMakeLists.txt

Loading...
View Options

src/policy/block/rtt.h

Loading...
View Options

src/policy/block/rtt.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/rtt_tests.cpp

Loading...