Details

Reviewers

PiRK
roqqit

Group Reviewers

Restricted Project

Commits

rABCccfbdd5df5fe: Compute the real-time hash target for the next block

Summary

Given some input parameters, compute the next minimum hash for a block to be avalanche accepted.
Only the computation is part of this diff.

Inspired by the research from https://ledger.pitt.edu/ojs/ledger/article/download/195/187/1008.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rtt_computation_lean

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30267
Build 60061: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-clang · build-clang-tidy · build-diff
Build 60060: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 6 2024, 13:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2024, 13:21

Fabien requested review of this revision.Sep 6 2024, 13:21

Fabien edited the summary of this revision. (Show Details)Sep 6 2024, 13:25

Harbormaster completed remote builds in B30206: Diff 49530.Sep 6 2024, 13:43

Fabien added a child revision: D16729: Reject blocks that violate the real time target policy.Sep 6 2024, 14:00

PiRK accepted this revision.Sep 6 2024, 15:13

This revision is now accepted and ready to land.Sep 6 2024, 15:13

roqqit accepted this revision.Sep 6 2024, 16:37

Got offline feedback that deserves looking at a design update

Update the algorithm

This revision is now accepted and ready to land.Sep 11 2024, 14:21

Typo

Harbormaster completed remote builds in B30253: Diff 49590.Sep 11 2024, 14:48

Harbormaster completed remote builds in B30254: Diff 49591.Sep 11 2024, 14:59

Improve comment on the windows selection

Harbormaster completed remote builds in B30259: Diff 49597.Sep 11 2024, 19:55

EDA -> DAA

Harbormaster completed remote builds in B30260: Diff 49598.Sep 11 2024, 20:20

roqqit requested changes to this revision.Sep 11 2024, 21:03

roqqit added inline comments.

src/policy/block/rtt.cpp
36 ↗	(On Diff #49598)	nit: this can be explicitly static also
src/test/rtt_tests.cpp
35–37 ↗	(On Diff #49598)	Make this check more comprehensive

This revision now requires changes to proceed.Sep 11 2024, 21:03

bytesofman added a subscriber: bytesofman.Sep 11 2024, 23:26

bytesofman added inline comments.

src/policy/block/rtt.cpp
23 ↗	(On Diff #49598)	i think either `these formulae` or `this formula`
33 ↗	(On Diff #49598)

Feedback + remove the 18th block in the test, this is confusing for no reason as block[0] is the previous block as per the GetNextRTTWorkRequired call.

Harbormaster completed remote builds in B30267: Diff 49606.Sep 12 2024, 07:40

PiRK accepted this revision.Sep 12 2024, 09:12

PiRK added inline comments.