Page MenuHomePhabricator
Differential D16728

Compute the real-time hash target for the next block
ClosedPublic
Actions

Authored by Fabien on Sep 6 2024, 13:21.

Details

Reviewers
PiRK
roqqit
Group Reviewers
Restricted Project
Commits
rABCccfbdd5df5fe: Compute the real-time hash target for the next block
Summary

Given some input parameters, compute the next minimum hash for a block to be avalanche accepted.
Only the computation is part of this diff.

Inspired by the research from https://ledger.pitt.edu/ojs/ledger/article/download/195/187/1008.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 6 2024, 13:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2024, 13:21
Fabien requested review of this revision.Sep 6 2024, 13:21
Fabien edited the summary of this revision. (Show Details)Sep 6 2024, 13:25
Harbormaster completed remote builds in B30206: Diff 49530.Sep 6 2024, 13:43
Fabien added a child revision: D16729: Reject blocks that violate the real time target policy.Sep 6 2024, 14:00
PiRK accepted this revision.Sep 6 2024, 15:13
This revision is now accepted and ready to land.Sep 6 2024, 15:13
roqqit accepted this revision.Sep 6 2024, 16:37
Fabien planned changes to this revision.Sep 9 2024, 07:19

Got offline feedback that deserves looking at a design update

Fabien updated this revision to Diff 49590.Sep 11 2024, 14:21

Update the algorithm

This revision is now accepted and ready to land.Sep 11 2024, 14:21
Fabien updated this revision to Diff 49591.Sep 11 2024, 14:22

Typo

Harbormaster completed remote builds in B30253: Diff 49590.Sep 11 2024, 14:48
Harbormaster completed remote builds in B30254: Diff 49591.Sep 11 2024, 14:59
Fabien updated this revision to Diff 49597.Sep 11 2024, 19:40

Improve comment on the windows selection

Harbormaster completed remote builds in B30259: Diff 49597.Sep 11 2024, 19:55
Fabien updated this revision to Diff 49598.Sep 11 2024, 19:57

EDA -> DAA

Harbormaster completed remote builds in B30260: Diff 49598.Sep 11 2024, 20:20
roqqit requested changes to this revision.Sep 11 2024, 21:03
roqqit added inline comments.
src/policy/block/rtt.cpp
36 ↗(On Diff #49598)

nit: this can be explicitly static also

src/test/rtt_tests.cpp
35–37 ↗(On Diff #49598)

Make this check more comprehensive

This revision now requires changes to proceed.Sep 11 2024, 21:03
bytesofman added a subscriber: bytesofman.Sep 11 2024, 23:26
bytesofman added inline comments.
src/policy/block/rtt.cpp
23 ↗(On Diff #49598)

i think either these formulae or this formula

33 ↗(On Diff #49598)
Fabien updated this revision to Diff 49606.Sep 12 2024, 07:24

Feedback + remove the 18th block in the test, this is confusing for no reason as block[0] is the previous block as per the GetNextRTTWorkRequired call.

Harbormaster completed remote builds in B30267: Diff 49606.Sep 12 2024, 07:40
PiRK accepted this revision.Sep 12 2024, 09:12
PiRK added inline comments.
src/test/rtt_tests.cpp
35 ↗(On Diff #49606)
Fabien updated this revision to Diff 49609.Sep 12 2024, 14:30

Fix typo

Harbormaster completed remote builds in B30270: Diff 49609.Sep 12 2024, 14:45
roqqit accepted this revision.Sep 12 2024, 15:38
This revision is now accepted and ready to land.Sep 12 2024, 15:38
Closed by commit rABCccfbdd5df5fe: Compute the real-time hash target for the next block (authored by Fabien). · Explain WhySep 17 2024, 19:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCccfbdd5df5fe: Compute the real-time hash target for the next block.
Fabien added a reverting change: D16772: Revert "Compute the real-time hash target for the next block".Sep 17 2024, 19:24
Fabien added a reverting change: rABCc116e0e02b0c: Revert "Compute the real-time hash target for the next block".Sep 17 2024, 19:33
Fabien mentioned this in D16773: Compute the real-time hash target for the next block.Sep 17 2024, 19:38
Fabien removed a child revision: D16729: Reject blocks that violate the real time target policy.Sep 17 2024, 19:41
Fabien mentioned this in rABCc40a40c05424: Compute the real-time hash target for the next block.Sep 17 2024, 20:34

Revision Contents
Changeset List

PathSize
src/
2 lines
policy/
block/
24 lines
60 lines
test/
1 line
97 lines

Diff 49684

View Options

src/CMakeLists.txt

Loading...
View Options

src/policy/block/rtt.h

Loading...
View Options

src/policy/block/rtt.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/rtt_tests.cpp

Loading...