Page MenuHomePhabricator

Return the RTT parameters in the block template
ClosedPublic

Authored by Fabien on Fri, Sep 6, 14:04.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC3740a55a700d: Return the RTT parameters in the block template
Summary

The parameters are chosen so that pool can either:

  • Directly read the real time target value from the rtt.nexttarget field;
  • Or compute it locally by using the other rtt.* parameters.

Depends on D16729.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Fri, Sep 6, 14:04
This revision is now accepted and ready to land.Fri, Sep 6, 17:20
Fabien planned changes to this revision.Mon, Sep 9, 07:19

Rebase, return all 4 header times in gbt, return the RTT as compact since the previous rationale no longer holds

This revision is now accepted and ready to land.Wed, Sep 11, 14:26
roqqit added inline comments.
src/rpc/mining.cpp
1203–1206 ↗(On Diff #49593)

nit

bytesofman added inline comments.
test/functional/abc_mining_rtt.py
187 ↗(On Diff #49593)

lgtm with two nits

test/functional/abc_mining_rtt.py
115 ↗(On Diff #49608)

unnecessary list access

164 ↗(On Diff #49608)

It takes some digging to figure out that instantiating an AvaP2PInterface causes a block to be mined via gen_proof, if the reader does not already know it. Maybe worth a short comment in get_quorum

Remove unnecessary list access and comment on get_ava_p2p_interface mining a block