The parameters are chosen so that pool can either:
- Directly read the real time target value from the rtt.nexttarget field;
- Or compute it locally by using the other rtt.* parameters.
Depends on D16729.
Details
Details
- Reviewers
roqqit - Group Reviewers
Restricted Project - Commits
- rABC3740a55a700d: Return the RTT parameters in the block template
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Rebase, return all 4 header times in gbt, return the RTT as compact since the previous rationale no longer holds
| src/rpc/mining.cpp | ||
|---|---|---|
| 1203–1206 ↗ | (On Diff #49593) | nit |
| test/functional/abc_mining_rtt.py | ||
|---|---|---|
| 187 ↗ | (On Diff #49593) | |
Comment Actions
lgtm with two nits
| test/functional/abc_mining_rtt.py | ||
|---|---|---|
| 115 ↗ | (On Diff #49608) | unnecessary list access |
| 164 ↗ | (On Diff #49608) | It takes some digging to figure out that instantiating an AvaP2PInterface causes a block to be mined via gen_proof, if the reader does not already know it. Maybe worth a short comment in get_quorum |