Page MenuHomePhabricator
Differential D16730

Return the RTT parameters in the block template
ClosedPublic
Actions

Authored by Fabien on Sep 6 2024, 14:04.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC3740a55a700d: Return the RTT parameters in the block template
Summary

The parameters are chosen so that pool can either:

  • Directly read the real time target value from the rtt.nexttarget field;
  • Or compute it locally by using the other rtt.* parameters.

Depends on D16729.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Sep 6 2024, 14:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2024, 14:04
Fabien requested review of this revision.Sep 6 2024, 14:04
Harbormaster completed remote builds in B30208: Diff 49532.Sep 6 2024, 14:27
roqqit accepted this revision.Sep 6 2024, 17:20
This revision is now accepted and ready to land.Sep 6 2024, 17:20
Fabien planned changes to this revision.Sep 9 2024, 07:19
Fabien edited the summary of this revision. (Show Details)Sep 11 2024, 14:26
Fabien updated this revision to Diff 49593.Sep 11 2024, 14:26

Rebase, return all 4 header times in gbt, return the RTT as compact since the previous rationale no longer holds

This revision is now accepted and ready to land.Sep 11 2024, 14:26
Harbormaster completed remote builds in B30256: Diff 49593.Sep 11 2024, 15:16
roqqit accepted this revision.Sep 11 2024, 21:22
roqqit added inline comments.
src/rpc/mining.cpp
1203–1206 ↗(On Diff #49593)

nit

bytesofman added a subscriber: bytesofman.Sep 11 2024, 23:33
bytesofman added inline comments.
test/functional/abc_mining_rtt.py
187 ↗(On Diff #49593)
Fabien updated this revision to Diff 49608.Sep 12 2024, 07:32

Feedback

Harbormaster completed remote builds in B30269: Diff 49608.Sep 12 2024, 07:54
PiRK added a subscriber: PiRK.Sep 12 2024, 13:50

lgtm with two nits

test/functional/abc_mining_rtt.py
115

unnecessary list access

164

It takes some digging to figure out that instantiating an AvaP2PInterface causes a block to be mined via gen_proof, if the reader does not already know it. Maybe worth a short comment in get_quorum

Fabien updated this revision to Diff 49610.Sep 12 2024, 14:32

Remove unnecessary list access and comment on get_ava_p2p_interface mining a block

Harbormaster completed remote builds in B30271: Diff 49610.Sep 12 2024, 15:07
Fabien updated this revision to Diff 49690.Sep 17 2024, 19:43

Rebase

Harbormaster completed remote builds in B30332: Diff 49690.Sep 17 2024, 20:32
Closed by commit rABC3740a55a700d: Return the RTT parameters in the block template (authored by Fabien). · Explain WhySep 17 2024, 20:34
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3740a55a700d: Return the RTT parameters in the block template.

Revision Contents
Changeset List

PathSize
src/
rpc/
72 lines
test/
functional/
195 lines

Diff 49608

View Options

src/rpc/mining.cpp

Loading...
View Options

test/functional/abc_mining_rtt.py

Loading...