[ecash-agora] Partial Agora offers: Add ALP support to plugin, `Agora` and `AgoraOffer`
ClosedPublic
Actions

Authored by tobias_ruck on Sep 12 2024, 23:27.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

rABCb18443e6bec6: [ecash-agora] Partial Agora offers: Add ALP support to plugin, `Agora` and…

Summary

In D16745 we added support for SLP, in this diff we add support for ALP.

The biggest difference is that offers use the OP_RETURN to advertize instead of the scriptSig like in SLP.

Depends on D16754.

Test Plan

npm run integration-tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-agora-partial-offer-alp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30275
Build 60077: Build Diff	ecash-agora-tests · ecash-agora-integration-tests
Build 60076: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Sep 12 2024, 23:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2024, 23:27

Harbormaster completed remote builds in B30275: Diff 49616.Sep 12 2024, 23:34

tobias_ruck published this revision for review.Sep 12 2024, 23:57

tobias_ruck retitled this revision from [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer` to [ecash-agora] Partial Agora offers: Add ALP support to plugin, `Agora` and `AgoraOffer`.Sep 13 2024, 10:22

tobias_ruck edited the summary of this revision. (Show Details)Sep 16 2024, 19:16

tobias_ruck added a parent revision: D16754: [ecash-agora] Limit token truncation level to 5 (SLP) and 3 (ALP).

rebase onto D16754.

Harbormaster completed remote builds in B30309: Diff 49660.Sep 16 2024, 19:39

bytesofman requested changes to this revision.Sep 18 2024, 21:34

bytesofman added inline comments.

modules/ecash-agora/src/agora.ts
259 ↗	(On Diff #49660)
modules/ecash-agora/tests/partial.alp.bigsats.test.ts
334 ↗	(On Diff #49660)	applies to this stack in general -- why do we not test the 0-index output? it does need to be exact for the tx to be valid, right?