[ecash-agora] Partial Agora offers: Add ALP support to plugin, `Agora` and `AgoraOffer`
Needs RevisionPublic
Actions

Authored by tobias_ruck on Thu, Sep 12, 23:27.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

In D16745 we added support for SLP, in this diff we add support for ALP.

The biggest difference is that offers use the OP_RETURN to advertize instead of the scriptSig like in SLP.

Depends on D16754.

Test Plan

npm run integration-tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-agora-partial-offer-alp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30309
Build 60145: Build Diff	ecash-agora-integration-tests · ecash-agora-tests
Build 60144: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Thu, Sep 12, 23:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Sep 12, 23:27

Harbormaster completed remote builds in B30275: Diff 49616.Thu, Sep 12, 23:34

tobias_ruck published this revision for review.Thu, Sep 12, 23:57

tobias_ruck retitled this revision from [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer` to [ecash-agora] Partial Agora offers: Add ALP support to plugin, `Agora` and `AgoraOffer`.Fri, Sep 13, 10:22

tobias_ruck edited the summary of this revision. (Show Details)Mon, Sep 16, 19:16

tobias_ruck added a parent revision: D16754: [ecash-agora] Limit token truncation level to 5 (SLP) and 3 (ALP).

rebase onto D16754.

Harbormaster completed remote builds in B30309: Diff 49660.Mon, Sep 16, 19:39

bytesofman requested changes to this revision.Wed, Sep 18, 21:34

bytesofman added inline comments.

modules/ecash-agora/src/agora.ts
259
modules/ecash-agora/tests/partial.alp.bigsats.test.ts
334	applies to this stack in general -- why do we not test the 0-index output? it does need to be exact for the tx to be valid, right?