Having a separate version number for chronik makes no sense since it's built-in bitcoind.
Details
- Reviewers
bytesofman tobias_ruck - Group Reviewers
Restricted Project - Commits
- rABC944808e2d1ee: [chronik] Set the version number to follow the version of bitcoind
ninja all check-all
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chronik_version
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Event Timeline
should also update the chronik-client test in this diff
/modules/chronik-client/test/integration/chronik_info.ts /test/functional/setup_scripts/chronik-client/chronik_info.py
Failed tests logs:
====== /chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection ====== AssertionError: expected 'v0.29.13-998017b395a0' to deeply equal '0.1.0' at /work/modules/chronik-client/test/integration/chronik_info.ts:76:40 at Generator.next (<anonymous>) at fulfilled (test/integration/chronik_info.ts:31:58) at processTicksAndRejections (node:internal/process/task_queues:95:5) + expected - actual -v0.29.13-998017b395a0 +0.1.0
Each failure log is accessible here:
/chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection
Failed tests logs:
====== /chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection ====== AssertionError: expected 'v0.29.13-ff5d0c34a65e' to deeply equal undefined at /work/modules/chronik-client/test/integration/chronik_info.ts:83:40 at Generator.next (<anonymous>) at fulfilled (test/integration/chronik_info.ts:31:58) at processTicksAndRejections (node:internal/process/task_queues:95:5)
Each failure log is accessible here:
/chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection
Otherwise looks good to me!
test/functional/test_framework/util.py | ||
---|---|---|
706 ↗ | (On Diff #49809) | Wouldn’t a regex here make more sense? This could break in unexpected ways if someone adds a letter and suddenly the version is off by one or has a leading space etc |
test/functional/test_framework/util.py | ||
---|---|---|
706 ↗ | (On Diff #49809) | I considered that but I don't think it's worth it:
|