Page MenuHomePhabricator

[chronik] Set the version number to follow the version of bitcoind
ClosedPublic

Authored by Fabien on Sep 24 2024, 19:55.

Details

Summary

Having a separate version number for chronik makes no sense since it's built-in bitcoind.

Test Plan
ninja all check-all

Event Timeline

Fabien requested review of this revision.Sep 24 2024, 19:55
bytesofman added a subscriber: bytesofman.

should also update the chronik-client test in this diff

/modules/chronik-client/test/integration/chronik_info.ts
/test/functional/setup_scripts/chronik-client/chronik_info.py
This revision now requires changes to proceed.Sep 24 2024, 20:04

Failed tests logs:

====== /chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection ======
AssertionError: expected 'v0.29.13-998017b395a0' to deeply equal '0.1.0'
    at /work/modules/chronik-client/test/integration/chronik_info.ts:76:40
    at Generator.next (<anonymous>)
    at fulfilled (test/integration/chronik_info.ts:31:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

      -v0.29.13-998017b395a0
      +0.1.0

Each failure log is accessible here:
/chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection

Fix the integration test

Typo in the ipc message key

Failed tests logs:

====== /chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection ======
AssertionError: expected 'v0.29.13-ff5d0c34a65e' to deeply equal undefined
    at /work/modules/chronik-client/test/integration/chronik_info.ts:83:40
    at Generator.next (<anonymous>)
    at fulfilled (test/integration/chronik_info.ts:31:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Each failure log is accessible here:
/chronik-info: gives us the chronik info and throws expected error on bad server connection./chronik-info gives us the chronik info and throws expected error on bad server connection

This revision is now accepted and ready to land.Sep 24 2024, 22:14
tobias_ruck added a subscriber: tobias_ruck.

Otherwise looks good to me!

test/functional/test_framework/util.py
706

Wouldn’t a regex here make more sense? This could break in unexpected ways if someone adds a letter and suddenly the version is off by one or has a leading space etc

This revision now requires changes to proceed.Sep 24 2024, 23:06
Fabien requested review of this revision.Sep 25 2024, 07:29
Fabien added inline comments.
test/functional/test_framework/util.py
706

I considered that but I don't think it's worth it:

  • The chances for this to change is low (except for package name) and other tests/features will break anyway
  • Maintaining a regex is simply more complicated and/or has more edge cases.
This revision is now accepted and ready to land.Sep 25 2024, 08:53