Use multiplication by SATOSHI to build various amounts.
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 15:16.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING606e1d142dbf: Use multiplication by SATOSHI to build various amounts.
rABC606e1d142dbf: Use multiplication by SATOSHI to build various amounts.

Summary

This ensure that we remove the implicit idea that we construct from satoshis.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

satmul

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3180
Build 4447: Bitcoin ABC Buildbot (legacy)
Build 4446: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2018, 15:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 15:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3180: Diff 4740.Sep 4 2018, 15:54

jasonbcox accepted this revision.Sep 4 2018, 17:30

This revision is now accepted and ready to land.Sep 4 2018, 17:30

Closed by commit rABC606e1d142dbf: Use multiplication by SATOSHI to build various amounts. (authored by deadalnix). · Explain WhySep 4 2018, 17:49

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bench/

mempool_eviction.cpp

14 lines

policy/

policy.h

2 lines

qt/

test/

uritests.cpp

12 lines

test/

blockcheck_tests.cpp

2 lines

blockencodings_tests.cpp

4 lines

4 lines

36 lines

52 lines

18 lines

29 lines

script_P2SH_tests.cpp

18 lines

script_tests.cpp

2 lines

transaction_tests.cpp

12 lines

undo_tests.cpp

2 lines

wallet/

test/

accounting_tests.cpp

26 lines

wallet_tests.cpp

8 lines

Diff 4740

View Options

src/bench/mempool_eviction.cpp

View Options

src/policy/policy.h

View Options

src/qt/test/uritests.cpp

View Options

src/test/blockcheck_tests.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/feerate_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/undo_tests.cpp

View Options

src/wallet/test/accounting_tests.cpp

View Options

src/wallet/test/wallet_tests.cpp

Use multiplication by SATOSHI to build various amounts.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4740

src/bench/mempool_eviction.cpp

src/policy/policy.h

src/qt/test/uritests.cpp

src/test/blockcheck_tests.cpp

src/test/blockencodings_tests.cpp

src/test/coins_tests.cpp

src/test/feerate_tests.cpp

src/test/mempool_tests.cpp

src/test/miner_tests.cpp

src/test/rpc_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_tests.cpp

src/test/transaction_tests.cpp

src/test/undo_tests.cpp

src/wallet/test/accounting_tests.cpp

src/wallet/test/wallet_tests.cpp

Use multiplication by SATOSHI to build various amounts.
ClosedPublic
Actions

Revision Contents
Changeset List