Page MenuHomePhabricator

scripted-diff: Rename ValidAsCString to ContainsNoNUL
ClosedPublic

Authored by PiRK on Nov 16 2024, 10:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2ce28a323c56: scripted-diff: Rename ValidAsCString to ContainsNoNUL
Summary
-BEGIN VERIFY SCRIPT-
 sed -i 's,ValidAsCString,ContainsNoNUL,g' $(git grep -l ValidAsCString)
-END VERIFY SCRIPT-

This concludes backport of core#25001
https://github.com/bitcoin/bitcoin/pull/25001/commits/fa7078d84fc2858a466bc1a85404f821df682538

Depends on D17151

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Nov 16 2024, 10:42

Tail of the build log:

[379/575] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[380/575] Linking C executable src/secp256k1/ecmult-bench
[381/575] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[382/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[383/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[384/575] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[385/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[386/575] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[387/575] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[388/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[389/575] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[390/575] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[391/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[392/575] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[393/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[394/575] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[395/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[396/575] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[397/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[398/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[399/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[400/575] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[401/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[402/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[403/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[404/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[405/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[406/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[407/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[408/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[409/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[410/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[411/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[412/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[413/575] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[414/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[415/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[416/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[417/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[418/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[419/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[420/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[421/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[422/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[423/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[424/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[425/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[426/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[427/575] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[428/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[429/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[430/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[431/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[432/575] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[433/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[434/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[435/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[436/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Nov 18 2024, 10:08