Page MenuHomePhabricator
Differential D17282

Add a new getinfo rpc
ClosedPublic
Actions

Authored by Fabien on Tue, Dec 3, 10:37.

Details

Reviewers
tobias_ruck
PiRK
Group Reviewers
Restricted Project
Commits
rABCd611537d0336: Add a new getinfo rpc
Summary

This returns the node version (which currently is in getnetworkinfo, which is counter intuitive) and whether avalanche is enabled.
This gives a fast (no lock) method to get the version and whether the node is avalanche enabled, to be used in the functional tests in a follow-up.
This RPC will be much faster than the bloated getnetworkinfo for such simple data.

Test Plan
./test/functional/test_runner.py abc_rpc_getinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Dec 3, 10:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 3, 10:37
Fabien requested review of this revision.Tue, Dec 3, 10:37
Fabien added a child revision: D17283: [test] Only sync proofs when avalanche is enabled.Tue, Dec 3, 10:48
Harbormaster completed remote builds in B31497: Diff 51361.Tue, Dec 3, 10:55
Fabien added a child revision: Restricted Differential Revision.Tue, Dec 3, 11:13
Fabien edited the summary of this revision. (Show Details)Tue, Dec 3, 13:12
Fabien updated this revision to Diff 51366.Tue, Dec 3, 13:18

Use get_cli_version

tobias_ruck accepted this revision.Tue, Dec 3, 13:21
This revision is now accepted and ready to land.Tue, Dec 3, 13:21
PiRK accepted this revision.Tue, Dec 3, 13:25
This revision was landed with ongoing or failed builds.Tue, Dec 3, 13:26
Closed by commit rABCd611537d0336: Add a new getinfo rpc (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd611537d0336: Add a new getinfo rpc.
Harbormaster completed remote builds in B31501: Diff 51366.Tue, Dec 3, 13:43

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
rpc/
34 lines
test/
functional/
32 lines

Diff 51369

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

test/functional/abc_rpc_getinfo.py

Loading...