Add simple big block test
ClosedPublic
Actions

Authored by freetrader on Jun 11 2017, 21:46.

Details

Reviewers

deadalnix
sickpig
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING434fe9f46253: Add simple big block test
rABC434fe9f46253: Add simple big block test

Summary

The abc-p2p-fullblocktest-simple.py test generates a 2MB block
and an oversize block under EB2 conditions.

This test is intended as a starting point to derive further cases and tests,
while we look into adapting p2p-fullblocktest.py as such (it is very complex and
hard to adapt to bigger block sizes and other consensus rule changes).

Depends on D171

Test Plan

qa/pull-tester/rpc-tests.py abc-p2p-fullblocktest-simple

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freetrader created this revision.Jun 11 2017, 21:46

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJun 11 2017, 21:46

deadalnix added inline comments.Jun 11 2017, 22:08

qa/rpc-tests/abc-p2p-fullblocktest-simple.py
47 ↗	(On Diff #385)	Be careful, this will need to be changed when changes to D171 are done.

Planning to change the command line option name to 'excessiveblocksize' as per D171 review comments.

Rename blocksizeacceptlimit option to excessiveblocksize

Also rename variables to avoid confusion.

Harbormaster completed remote builds in B236: Diff 389.Jun 11 2017, 22:22

sickpig added inline comments.Jun 11 2017, 22:45

qa/rpc-tests/abc-p2p-fullblocktest-simple.py
233 ↗	(On Diff #385)	why not just using `=` rather than `<=` ?

freetrader added inline comments.Jun 11 2017, 22:53

qa/rpc-tests/abc-p2p-fullblocktest-simple.py
47 ↗	(On Diff #385)	+1
233 ↗	(On Diff #385)	Because I'm testing if the concrete size of the block will fit in to whatever the upper cap is currently set to in the test. It just has to fit in. We should add more test steps to try increase the limit, then check again with a > 2MB block etc.

For what it's worth, I arc patched that diff and ran the test, it passes.

If you run this test with --nocleanup , it will leave behind a /tmp/test* folder (telling you the name).

You can then find in there a node0/regtest/debug.log which shows that the client actually accepted the bigger block.

It's missing addition of the to the list of tests in rpc-tester

It's missing addition to the list

qa/rpc-tests/abc-p2p-fullblocktest-simple.py
234 ↗	(On Diff #389)	So this creates a block with block size whatever is given as block_size ? Can we make sure it actually generate a block larger than LEGACY_MAX_BLOCK_SIZE ? because if not, then we are testing nothing.