Remove init of global config mid-test in miner_tests.cpp
ClosedPublic
Actions

Authored by jasonbcox on Sep 6 2018, 16:46.

Details

Reviewers

deadalnix
Mengerian
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING090127c4042c: Remove init of global config mid-test in miner_tests.cpp
rABC090127c4042c: Remove init of global config mid-test in miner_tests.cpp

Summary

Removes the possibility of accidentally using two different configs, which can cause these tests fail. Discovered while working on D1519, although that diff will not be applied, the issue is still valid.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 6 2018, 16:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2018, 16:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Sep 6 2018, 17:06

This revision is now accepted and ready to land.Sep 6 2018, 17:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3218: Diff 4797.Sep 6 2018, 17:21

Closed by commit rABC090127c4042c: Remove init of global config mid-test in miner_tests.cpp (authored by jasonbcox). · Explain WhySep 6 2018, 19:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

miner_tests.cpp

30 lines

Diff 4802

View Options

Remove init of global config mid-test in miner_tests.cppClosedPublicActions