Page MenuHomePhabricator

Changed CMessageHeader::pchCommand to use a C++11 array and updated its various uses to reflect this.
ClosedPublic

Authored by nakihito on Sep 9 2018, 19:43.

Details

Summary

Addresses T247. Changed CMessageHeader::pchCommand to be implimented as a C++11 array rather than a static array and updated its various uses to reflect this.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Sep 9 2018, 19:43
Owners added a reviewer: Restricted Owners Package.Sep 9 2018, 19:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2018, 19:43
deadalnix accepted this revision.Sep 10 2018, 09:06
This revision is now accepted and ready to land.Sep 10 2018, 09:06
deadalnix requested changes to this revision.Sep 10 2018, 09:08

Please figure out why the build isn't passing before proceeding.

This revision now requires changes to proceed.Sep 10 2018, 09:08
nakihito updated this revision to Diff 4882.Sep 11 2018, 20:44

Made change to GetCommand() to more closely resemble original.

deadalnix accepted this revision.Sep 12 2018, 00:05
This revision is now accepted and ready to land.Sep 12 2018, 00:05
This revision was automatically updated to reflect the committed changes.