Page MenuHomePhabricator
Differential D1743

Changed CMessageHeader::pchCommand to use a C++11 array and updated its various uses to reflect this.
ClosedPublic
Actions

Authored by nakihito on Sep 9 2018, 19:43.

Details

Reviewers
deadalnix
jasonbcox
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING13048d9dee12: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various…
rABC13048d9dee12: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various…
Summary

Addresses T247. Changed CMessageHeader::pchCommand to be implimented as a C++11 array rather than a static array and updated its various uses to reflect this.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
CMessageHeaderCppArray
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3272
Build 4631: Bitcoin ABC Buildbot (legacy)
Build 4630: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 9 2018, 19:43
Owners added a reviewer: Restricted Owners Package.Sep 9 2018, 19:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2018, 19:43
teamcity added a subscriber: teamcity.Sep 9 2018, 19:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 9 2018, 20:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3235: Diff 4827!Sep 9 2018, 20:18
teamcity added a comment.Sep 9 2018, 21:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 9 2018, 22:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix accepted this revision.Sep 10 2018, 09:06
This revision is now accepted and ready to land.Sep 10 2018, 09:06
deadalnix requested changes to this revision.Sep 10 2018, 09:08

Please figure out why the build isn't passing before proceeding.

This revision now requires changes to proceed.Sep 10 2018, 09:08
nakihito updated this revision to Diff 4882.Sep 11 2018, 20:44

Made change to GetCommand() to more closely resemble original.

teamcity added a comment.Sep 11 2018, 20:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3272: Diff 4882.Sep 11 2018, 21:22
teamcity added a comment.Sep 11 2018, 21:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Sep 12 2018, 00:05
This revision is now accepted and ready to land.Sep 12 2018, 00:05
Closed by commit rABC13048d9dee12: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various… (authored by nakihito). · Explain WhySep 17 2018, 18:43
This revision was automatically updated to reflect the committed changes.
roqqit mentioned this in D16384: Cleanup commented protocol code.Jun 26 2024, 19:30
roqqit mentioned this in rABCb5acc84862a2: Cleanup commented protocol code.Jun 26 2024, 20:07

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines
18 lines

Diff 4882

View Options

src/net.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

src/protocol.cpp

Loading...