Differential D17438
[Cashtab] Allow typed input for agora quantity selection Authored by bytesofman on Tue, Dec 31, 00:13.
Details
OrderBook was originally built with a slider that only allowed selection of the discrete values allowed by Agora. This ended up being bad UX. Almost impossible to select an amount even close to what you want. Replace with typed input. The tradeoff is that we must validate this input and also present the user the delta (if any) between what was input and what is the closest thing we can use. imo this is better UX though. We had many users complain about the slider. npm test
Diff Detail
Event TimelineComment Actions Correct bad comments, add better comments in useEffect for when takeTokenQtyDecimalized is set
Comment Actions Is there a guarantee that the selected buy amount is <= to the user requested amount ?
Comment Actions Here's the function in question https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/modules/ecash-agora/src/partial.ts#L597 /**
* Prepare the given acceptedTokens amount for the Script; `acceptedTokens`
* must have the lowest numTokenTruncBytes bytes set to 0 and this function
* does this for us.
**/
public prepareAcceptedTokens(acceptedTokens: bigint): bigint {
const numTokenTruncBits = BigInt(8 * this.numTokenTruncBytes);
return (acceptedTokens >> numTokenTruncBits) << numTokenTruncBits;
}I hadn't looked into it before, but looks like yes -- given an input acceptedTokens this function can only return a value <= acceptedTokens So, gives me some more confidence about this UX approach. When I made this diff I didn't look into this, just figured the delta was an acceptable trade-off to the UX of selecting, as long as the user can see the delta before buying.
Comment Actions typo fix, make sure you display the actual amount bought in the buy success notification | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
