Page MenuHomePhabricator
Differential D17445

[cashtab] Don't open agora offers on a new tab
ClosedPublic
Actions

Authored by Fabien on Jan 1 2025, 08:17.

Details

Reviewers
emack
bytesofman
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCd72d9d5b7883: [cashtab] Don't open agora offers on a new tab
Summary

This is the same website, and should not open in a new tab. This makes the mobile experience counter-intuitive.

Ref T3715

Test Plan

Run cashtab and check it opens in the same tab

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab_agora_open_same_tab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31862
Build 63216: Build Diffcashtab-tests
Build 63215: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 1 2025, 08:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 1 2025, 08:17
Fabien requested review of this revision.Jan 1 2025, 08:17
Fabien edited the summary of this revision. (Show Details)Jan 1 2025, 08:19
Fabien added a task: Restricted Maniphest Task.
Harbormaster completed remote builds in B31862: Diff 51887.Jan 1 2025, 08:22
emack accepted this revision.Jan 1 2025, 10:20
emack added subscribers: bytesofman, emack.

@bytesofman - as a side note, current versions of major browsers are all automatically assuming rel="noopener noreferrer" when opening links in a new window.

This revision is now accepted and ready to land.Jan 1 2025, 10:20
bytesofman accepted this revision.Jan 1 2025, 13:05
Closed by commit rABCd72d9d5b7883: [cashtab] Don't open agora offers on a new tab (authored by Fabien). · Explain WhyJan 1 2025, 14:07
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd72d9d5b7883: [cashtab] Don't open agora offers on a new tab.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Agora/
OrderBook/
2 lines

Diff 51887

View Options

cashtab/src/components/Agora/OrderBook/index.tsx

Loading...