Page MenuHomePhabricator
Differential D1744

net: pass CConnman via pointer rather than reference
ClosedPublic
Actions

Authored by deadalnix on Sep 10 2018, 09:03.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING04473d4dba76: net: pass CConnman via pointer rather than reference
rABC04473d4dba76: net: pass CConnman via pointer rather than reference
Summary

There are a few too many edge-cases here to make this a scripted diff.

The following commits will move a few functions into PeerLogicValidation, where
the local connman instance can be used. This change prepares for that usage.

This is a backport from commit 28f11e9406b185dc87144f1f29af0d93eb115b4e from Core.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
connmanptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3238
Build 4563: Bitcoin ABC Buildbot (legacy)
Build 4562: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 10 2018, 09:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 09:03
teamcity added a subscriber: teamcity.Sep 10 2018, 09:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 09:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3236: Diff 4828!Sep 10 2018, 09:42
deadalnix updated this revision to Diff 4830.Sep 10 2018, 10:53

rebase

teamcity added a comment.Sep 10 2018, 10:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3238: Diff 4830.Sep 10 2018, 11:32
teamcity added a comment.Sep 10 2018, 11:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1749: net: use an interface class rather than signals for message processing.Sep 10 2018, 12:33
schancel accepted this revision.Sep 10 2018, 19:16
This revision is now accepted and ready to land.Sep 10 2018, 19:16
Closed by commit rABC04473d4dba76: net: pass CConnman via pointer rather than reference (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 10 2018, 19:52
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
8 lines
4 lines
252 lines
test/
22 lines

Diff 4830

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/DoS_tests.cpp

Loading...