Page MenuHomePhabricator
Differential D17457

[Cashtab] Prevent creation of unacceptable agora offers
ClosedPublic
Actions

Authored by bytesofman on Thu, Jan 2, 15:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4bb8240bd8d5: [Cashtab] Prevent creation of unacceptable agora offers
Summary

Bug fix. the UI was not resetting the max on the slider as expected, nor properly validating for unacceptable offer creation.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
no-creating-unacceptable-agora-offers
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31889
Build 63270: Build Diffcashtab-tests
Build 63269: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Jan 2, 15:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 2, 15:14
Harbormaster completed remote builds in B31889: Diff 51922.Thu, Jan 2, 15:25
bytesofman updated this revision to Diff 51928.Thu, Jan 2, 17:16

Update useEffect to validate min qty when total qty changes, remove useEffect that changed min qty when total qty changed

bytesofman updated this revision to Diff 51929.Thu, Jan 2, 17:19

remove debug log, confirm button disabled on error event

bytesofman mentioned this in D17426: [Cashtab] Do not show wild-ass agora offers in OrderBook.Thu, Jan 2, 17:20
Harbormaster completed remote builds in B31893: Diff 51928.Thu, Jan 2, 17:22
Harbormaster completed remote builds in B31894: Diff 51929.Thu, Jan 2, 17:25
bytesofman published this revision for review.Thu, Jan 2, 17:30
bytesofman added inline comments.
cashtab/src/components/Etokens/Token/index.tsx
665 ↗(On Diff #51928)

imo this was the wrong approach. we do not want to "auto change" Something that the user had set. Also this was only working for typed adjustments.

Fabien accepted this revision.Thu, Jan 2, 17:44
This revision is now accepted and ready to land.Thu, Jan 2, 17:44
Closed by commit rABC4bb8240bd8d5: [Cashtab] Prevent creation of unacceptable agora offers (authored by bytesofman). · Explain WhyThu, Jan 2, 17:56
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC4bb8240bd8d5: [Cashtab] Prevent creation of unacceptable agora offers.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Etokens/
Token/
6 lines

Diff 51922

View Options

cashtab/src/components/Etokens/Token/index.tsx

Loading...