Page MenuHomePhabricator

[doc] Rename some spec file to remove the activation date
ClosedPublic

Authored by Fabien on Mon, Jan 27, 19:21.

Details

Summary

We already have activation specifications, this is redundant.

Depends on D17597.

Test Plan

Read the docs. All. Carefully.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rename_standards
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32231
Build 63952: Build Diff
Build 63951: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Mon, Jan 27, 19:21
Mengerian requested changes to this revision.Mon, Jan 27, 19:26
Mengerian added a subscriber: Mengerian.

Some links to bitcoincash.org github

doc/standards/2020-05-15-upgrade.md
30

Problem here, it's linking to the old bitcoin cash github

36

ditto

doc/standards/2020-11-15-upgrade.md
27

ditto

This revision now requires changes to proceed.Mon, Jan 27, 19:26
doc/standards/cashaddr.md
196 ↗(On Diff #52411)

This one should actually stay the same

fix cashaddr.md link (need to reference the legacy spec here)

Mengerian added inline comments.
doc/standards/op_return-prefix-guideline.md
3 ↗(On Diff #52412)

Seems like this link may be meant to refer to the original BCH document on purpose.

33 ↗(On Diff #52412)

Ditto

modules/ecashaddrjs/README.md
7 ↗(On Diff #52412)

Was the point of this to say that it's also compliant with BCH Cashaddr, in addition to XEC?

In that case, the original link might make sense

@bytesofman

Fabien marked 2 inline comments as done.

Revert link to op_return-prefix-guideline.md

modules/ecashaddrjs/README.md
7 ↗(On Diff #52412)

Yeah I'm not sure what 'original' means here.

modules/ecashaddrjs/README.md
7 ↗(On Diff #52412)

Well if you look at the things being linked in the original vs. the new link, it's totally different docs.

Revert link update in the ecashaddrjs README

modules/ecashaddrjs/README.md
7 ↗(On Diff #52412)

OK reverted

This revision is now accepted and ready to land.Wed, Jan 29, 22:35