Page MenuHomePhabricator
Differential D1763

[P2P] Timeout for headers sync
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2018, 11:13.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGaf85afbd1d7a: [P2P] Timeout for headers sync
rABCaf85afbd1d7a: [P2P] Timeout for headers sync
Summary

Add timeout for headers sync

At startup, we choose one peer to serve us the headers chain, until
our best header is close to caught up. Disconnect this peer if more
than 15 minutes + 1ms/expected_header passes and our best header
is still more than 1 day away from current time.

This is a backport of core PR10345

Part of it was made redundant after D1130

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr10345
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3305
Build 4694: Bitcoin ABC Buildbot (legacy)
Build 4693: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2018, 11:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2018, 11:13
teamcity added a subscriber: teamcity.Sep 11 2018, 11:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1764: Disconnect from outbound peers with bad headers chains.Sep 11 2018, 11:49
teamcity added a comment.Sep 11 2018, 11:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3265: Diff 4874.Sep 11 2018, 11:50
deadalnix updated this revision to Diff 4928.Sep 15 2018, 17:41

rebase

teamcity added a comment.Sep 15 2018, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 15 2018, 19:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3305: Diff 4928.Sep 15 2018, 19:00
schancel accepted this revision.Sep 16 2018, 22:20
This revision is now accepted and ready to land.Sep 16 2018, 22:20
Closed by commit rABCaf85afbd1d7a: [P2P] Timeout for headers sync (authored by Suhas Daftuar <sdaftuar@chaincode.com>, committed by deadalnix). · Explain WhySep 17 2018, 07:42
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
47 lines

Diff 4928

View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...