Page MenuHomePhabricator
Differential D1796

Fix git clone instructions
ClosedPublic
Actions

Authored by jasonbcox on Sep 21 2018, 17:48.

Details

Reviewers
deadalnix
schancel
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING45e01a501299: Fix git clone instructions
rABC45e01a501299: Fix git clone instructions
Summary

Reported here: https://github.com/Bitcoin-ABC/bitcoin-abc/issues/255 qshuai didn't want to make the change himself, so I've done it instead.

Test Plan

N/A

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 21 2018, 17:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2018, 17:48
teamcity added a subscriber: teamcity.Sep 21 2018, 17:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3339: Diff 4991.Sep 21 2018, 18:08
teamcity added a comment.Sep 21 2018, 18:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox edited the summary of this revision. (Show Details)Sep 21 2018, 20:27
schancel requested changes to this revision.Sep 23 2018, 05:32
schancel added inline comments.
doc/build-osx.md
37 ↗(On Diff #4991)

Building shouldn't even include how to clone the repo.

This revision now requires changes to proceed.Sep 23 2018, 05:32
jasonbcox planned changes to this revision.Sep 23 2018, 16:44
jasonbcox added inline comments.
doc/build-osx.md
37 ↗(On Diff #4991)

True. IIRC we discussed this a long time ago and figured people downloading source from Github was expected. I can rewrite step 1 to point to CONTRIBUTING.md so that we aren't duplicating instructions instead.

jasonbcox retitled this revision from Fix git clone instructions in build-osx.md to Fix git clone instructions.Sep 25 2018, 19:29
jasonbcox updated this revision to Diff 5036.Sep 25 2018, 19:30

Fixed unix doc as well

doc/build-osx.md
37 ↗(On Diff #4991)

Looked over the docs again. Every doc has a reference to github for normal building instructions. I think this makes sense since many builders may not be interested in making contributions.

teamcity added a comment.Sep 25 2018, 19:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3360: Diff 5036.Sep 25 2018, 19:48
teamcity added a comment.Sep 25 2018, 19:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Sep 26 2018, 12:40
schancel accepted this revision.Sep 26 2018, 20:53
This revision is now accepted and ready to land.Sep 26 2018, 20:53
Closed by commit rABC45e01a501299: Fix git clone instructions (authored by jasonbcox). · Explain WhySep 26 2018, 21:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
2 lines
2 lines

Diff 5085

View Options

doc/build-osx.md

Loading...
View Options

doc/build-unix.md

Loading...