Page MenuHomePhabricator
Differential D18061

[Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page
Needs RevisionPublic
Actions

Authored by bytesofman on Wed, May 7, 14:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Cashtab send screen supports bip21 query strings. We should allow users to make their own to support point of sale use case.

This is a first pass, where we support custom XEC or FIRMA amounts.

It can be extended to support arbitary token quantities or other bip21.

new receive screen:

image.png (627×508 px, 27 KB)

Test Plan

npm test

deployed live at test site, check at https://cashtab-local-dev.netlify.app/#/receive

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip21-qr-codes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33240
Build 65963: Build Diffcashtab-tests
Build 65962: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, May 7, 14:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 7, 14:00
Harbormaster completed remote builds in B33237: Diff 53891.Wed, May 7, 14:05
bytesofman updated this revision to Diff 53895.Wed, May 7, 17:13

add tests

Harbormaster completed remote builds in B33240: Diff 53895.Wed, May 7, 17:18
bytesofman published this revision for review.Wed, May 7, 17:19
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Thu, May 8, 10:13
Fabien added a subscriber: Fabien.

@bot preview-cashtab

cashtab/src/components/Common/Buttons.tsx
162

? why would you want a boolean to be nullable ?

cashtab/src/components/Receive/Receive.tsx
1

Macro whatyearisit:

This revision now requires changes to proceed.Thu, May 8, 10:13
Fabien added a comment.Thu, May 8, 10:15

@bot preview-cashtab

teamcity awarded a token.Thu, May 8, 10:15
teamcity added a comment.Thu, May 8, 10:18

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.83.66.92:41822 for the next 60 minutes.

teamcity updated a token.Thu, May 8, 10:19
teamcity added a comment.Thu, May 8, 10:22

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41715 for the next 60 minutes.

Fabien added a comment.Thu, May 8, 10:27

Can we have the unit in the amount input field ? IMO it avoids confusion better than the icon only, and 10 XEC is very different from 10 FIRMA

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Common/
2 lines
4 lines
9 lines
Receive/
QRCode.tsx
QRCode.js
68 lines
125 lines
__tests__/
66 lines
48 lines
validation/
__tests__/
13 lines
fixtures/
172 lines
56 lines

Diff 53895

View Options

cashtab/src/components/Common/Buttons.tsx

Loading...
View Options

cashtab/src/components/Common/Inputs.tsx

Loading...
View Options

cashtab/src/components/Common/Switch.tsx

Loading...
View Options

cashtab/src/components/Receive/QRCode.js

Loading...
View Options

cashtab/src/components/Receive/QRCode.tsx

Loading...
View Options

cashtab/src/components/Receive/Receive.js

Loading...
View Options

cashtab/src/components/Receive/Receive.tsx

Loading...
View Options

cashtab/src/components/Receive/__tests__/Receive.test.js

Loading...
View Options

cashtab/src/components/Receive/styled.ts

Loading...
View Options

cashtab/src/validation/__tests__/index.test.js

Loading...
View Options

cashtab/src/validation/fixtures/vectors.js

Loading...
View Options

cashtab/src/validation/index.ts

Loading...