Page MenuHomePhabricator
Differential D18256

net: reduce LOCK(cs_main) scope in ProcessGetBlockData
ClosedPublic
Actions

Authored by PiRK on Jun 14 2025, 14:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc5910098cce8: net: reduce LOCK(cs_main) scope in ProcessGetBlockData
Summary

This also changes behavior if ReadBlockFromDisk or
ReadRawBlockFromDisk fails. Previously, the node would crash
due to an assert. This has been replaced with logging the error,
disconnecting the peer, and returning early.

This concludes backport of core#26326
https://github.com/bitcoin/bitcoin/pull/26326/commits/75d27fefc7a04ebdda7be5724a014b6a896e7325
Depends on D18255

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 14 2025, 14:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2025, 14:07
PiRK requested review of this revision.Jun 14 2025, 14:07
teamcity edited the summary of this revision. (Show Details)Jun 14 2025, 14:07
Harbormaster completed remote builds in B33631: Diff 54490.Jun 14 2025, 14:09
teamcity added a comment.Jun 14 2025, 14:09
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[400/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[401/586] Linking CXX static library src/libcommon.a
[402/586] Linking CXX shared library src/libbitcoinconsensus.so.0.31.6
[403/586] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[404/586] Linking CXX executable src/bitcoin-cli
[405/586] Linking CXX executable src/bitcoin-tx
[406/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[411/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[413/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[416/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[419/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[423/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[426/586] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[428/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[431/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[434/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[436/586] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[437/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[441/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[442/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[444/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[445/586] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[446/586] Linking CXX executable src/iguana/iguana
[447/586] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[448/586] Linking CXX static library src/wallet/libwallet.a
[449/586] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[450/586] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[451/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[452/586] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[453/586] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[454/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[455/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[456/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[457/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK planned changes to this revision.Jun 14 2025, 14:10
teamcity added a comment.Jun 14 2025, 14:10
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[400/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[401/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[402/586] Linking CXX executable src/bitcoin-tx
[403/586] Building CXX object src/CMakeFiles/server.dir/node/blockstorage.cpp.o
[404/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/586] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[406/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[411/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[413/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[416/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[419/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[423/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[426/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[428/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[431/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[432/586] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[434/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[436/586] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[437/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[441/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/586] Linking CXX executable src/iguana/iguana
[445/586] Linking CXX static library src/wallet/libwallet.a
[446/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[447/586] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[448/586] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[449/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[450/586] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[451/586] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[452/586] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[453/586] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[454/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[455/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[456/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[457/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Jun 14 2025, 14:10
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[400/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[401/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[402/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[403/586] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[404/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/586] Building CXX object src/CMakeFiles/server.dir/node/blockstorage.cpp.o
[406/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[411/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[413/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[416/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[419/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[423/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[426/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[428/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[431/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[432/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[434/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[436/586] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o
[437/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[441/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/586] Linking CXX static library src/wallet/libwallet.a
[443/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[444/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[445/586] Linking CXX executable src/iguana/iguana
[446/586] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[447/586] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[448/586] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[449/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[450/586] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[451/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[452/586] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[453/586] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[454/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[455/586] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[456/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[457/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Jun 14 2025, 14:10
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[399/584] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[400/584] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[401/584] Linking CXX executable src/bitcoin-tx
[402/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[403/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[404/584] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[405/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[406/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[407/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[408/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[409/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[410/584] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[411/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[413/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[414/584] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[415/584] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[416/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[417/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[418/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[419/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[420/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[421/584] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[422/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[423/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[424/584] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[425/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[426/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[427/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[428/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[429/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[430/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[431/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[432/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[433/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[434/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[435/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[436/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[437/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[438/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[439/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[440/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[441/584] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[442/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[443/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[444/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[445/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[446/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[447/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[448/584] Linking CXX executable src/iguana/iguana
[449/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[450/584] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[451/584] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[452/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[453/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[454/584] Linking CXX static library src/wallet/libwallet.a
[455/584] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[456/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Jun 14 2025, 14:11
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[510/663] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[511/663] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[512/663] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[513/663] Linking C static library src/secp256k1/libsecp256k1.a
[514/663] Linking CXX static library src/libbitcoinconsensus.a
[515/663] Linking CXX static library src/libscript.a
[516/663] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o
[517/663] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[518/663] Linking CXX static library src/libcommon.a
[519/663] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[520/663] Linking C executable src/secp256k1/recover-bench
[521/663] Linking CXX shared library src/libbitcoinconsensus.so.0.31.6
[522/663] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[523/663] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[524/663] Linking C executable src/secp256k1/verify-bench
[525/663] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[526/663] Linking CXX executable src/bitcoin-cli
[527/663] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[528/663] Linking C executable src/secp256k1/sign-bench
[529/663] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[530/663] Linking C executable src/secp256k1/internal-bench
[531/663] Linking CXX executable src/bitcoin-tx
[532/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[533/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[534/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[535/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[536/663] Linking C executable src/secp256k1/ecmult-bench
[537/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[538/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[539/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[540/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[541/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[542/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[543/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[544/663] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[545/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[546/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[547/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[548/663] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[549/663] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[550/663] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[551/663] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[552/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[553/663] Linking CXX executable src/iguana/iguana
[554/663] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[555/663] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[556/663] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[557/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[558/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/node/blockstorage.cpp.o
[559/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[560/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
[561/663] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[562/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[563/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[564/663] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[565/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
[566/663] Linking CXX static library src/libbitcoinkernel.a
[567/663] Linking CXX executable src/bitcoin-chainstate
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
PiRK updated this revision to Diff 54491.Jun 14 2025, 14:19

fix stuff

Harbormaster completed remote builds in B33632: Diff 54491.Sat, Jun 14, 14:29
PiRK added a child revision: D18257: refactor: Use reference instead of pointer in IsBlockPruned.Sat, Jun 14, 14:56
Fabien accepted this revision.Tue, Jun 17, 07:57
This revision is now accepted and ready to land.Tue, Jun 17, 07:57
Closed by commit rABCc5910098cce8: net: reduce LOCK(cs_main) scope in ProcessGetBlockData (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhyTue, Jun 17, 09:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc5910098cce8: net: reduce LOCK(cs_main) scope in ProcessGetBlockData.

Revision Contents
Changeset List

PathSize
src/
135 lines

Diff 54506

View Options

src/net_processing.cpp

Loading...