Differential D18255

net: reduce LOCK(cs_main) scope in GETBLOCKTXN
ClosedPublic
Actions

Authored by PiRK on Jun 14 2025, 14:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCca505b1524f0: net: reduce LOCK(cs_main) scope in GETBLOCKTXN

Summary

Also adds a static assertion that MAX_BLOCKTXN_DEPTH <= MIN_BLOCKS_TO_KEEP

from the PR description:

Inspired by core#26308

(backported in D13052 -- D13057)

This is a partial backport of core#26326
https://github.com/bitcoin/bitcoin/pull/26326/commits/613a45cd4b5482aedbdc7c61c839ea05996935c6

Test Plan

With Debug:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 14 2025, 14:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2025, 14:05

PiRK requested review of this revision.Jun 14 2025, 14:05

teamcity edited the summary of this revision. (Show Details)Jun 14 2025, 14:05

PiRK added a child revision: D18256: net: reduce LOCK(cs_main) scope in ProcessGetBlockData.Jun 14 2025, 14:07

Harbormaster completed remote builds in B33630: Diff 54489.Jun 14 2025, 14:13

Fabien accepted this revision.Jun 17 2025, 07:53

This revision is now accepted and ready to land.Jun 17 2025, 07:53

Closed by commit rABCca505b1524f0: net: reduce LOCK(cs_main) scope in GETBLOCKTXN (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhyJun 17 2025, 09:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCca505b1524f0: net: reduce LOCK(cs_main) scope in GETBLOCKTXN.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

24 lines

Diff 54505

View Options

net: reduce LOCK(cs_main) scope in GETBLOCKTXNClosedPublicActions