logging: Replace uses of LogPrintfCategory
ClosedPublic
Actions

Authored by PiRK on Jun 19 2025, 13:14.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC59844d444b37: logging: Replace uses of LogPrintfCategory

Summary

Replace LogPrintfCategory with alternative unconditional log statements.

Remove LogPrintfCategory (would be done after core#30790 if not for missing benchmark backports, we can do it immediately)

This concludes backport of core#28318
https://github.com/bitcoin/bitcoin/pull/28318/commits/e60fc7d5d34f23cccbff6e4f5f3d716fa8dad50c

Depends on D18275

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr25614

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33669
Build 66817: Build Diff	build-clang · lint-circular-dependencies · build-clang-tidy · build-diff · build-without-wallet · build-debug
Build 66816: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 19 2025, 13:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2025, 13:14

PiRK requested review of this revision.Jun 19 2025, 13:14

teamcity edited the summary of this revision. (Show Details)Jun 19 2025, 13:14

Harbormaster completed remote builds in B33663: Diff 54537.Jun 19 2025, 13:59

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[203/528] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/options_tests.cpp.o
[204/528] pow: testing daa_tests
[205/528] Running utility command for check-pow-daa_tests
[206/528] pow: testing eda_tests
[207/528] Automatic MOC for target test_bitcoin-qt
[208/528] Running utility command for check-pow-eda_tests
[209/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[210/528] pow: testing grasberg_tests
[211/528] Running utility command for check-pow-grasberg_tests
[212/528] Test Bitcoin utilities...
[213/528] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[214/528] avalanche: testing voterecord_tests
[215/528] Running utility command for check-avalanche-voterecord_tests
[216/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[217/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[218/528] pow: testing aserti32d_tests
[219/528] Running utility command for check-pow-aserti32d_tests
[220/528] Running pow test suite
PASSED: pow test suite
[221/528] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[222/528] avalanche: testing peermanager_tests
[223/528] Linking CXX executable src/seeder/test/test-seeder
[224/528] Running utility command for check-avalanche-peermanager_tests
[225/528] seeder: testing db_tests
[226/528] seeder: testing message_writer_tests
[227/528] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[228/528] Running utility command for check-seeder-db_tests
[229/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[230/528] Running utility command for check-seeder-message_writer_tests
[231/528] seeder: testing parse_name_tests
[232/528] seeder: testing options_tests
[233/528] Running utility command for check-seeder-parse_name_tests
[234/528] seeder: testing p2p_messaging_tests
[235/528] seeder: testing write_name_tests
[236/528] Running utility command for check-seeder-p2p_messaging_tests
[237/528] Running utility command for check-seeder-options_tests
[238/528] Running utility command for check-seeder-write_name_tests
[239/528] Running seeder test suite
PASSED: seeder test suite
[240/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[241/528] avalanche: testing processor_tests
[242/528] Running utility command for check-avalanche-processor_tests
[243/528] Running avalanche test suite
PASSED: avalanche test suite
[244/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[245/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[246/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[247/528] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[248/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[249/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[250/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[251/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[252/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[253/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[254/528] Linking CXX executable src/qt/test/test_bitcoin-qt
[255/528] bitcoin-qt: testing test_bitcoin-qt
[256/528] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

PASSED                    [ 90%]##teamcity[testFinished timestamp='2025-06-19T14:00:34.512' duration='15' flowId='tests.test_iguana.test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']

tests/test_iguana.py::test_redeem_script_cleanstack ##teamcity[testStarted timestamp='2025-06-19T14:00:34.512' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_cleanstack' metainfo='test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']
PASSED               [ 95%]##teamcity[testFinished timestamp='2025-06-19T14:00:34.530' duration='17' flowId='tests.test_iguana.test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']

tests/test_iguana.py::test_redeem_script_input_sigchecks ##teamcity[testStarted timestamp='2025-06-19T14:00:34.531' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' metainfo='test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']
PASSED          [100%]##teamcity[testFinished timestamp='2025-06-19T14:00:34.562' duration='29' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']


============================== 20 passed in 0.59s ==============================
[205/521] Automatic MOC for target test_bitcoin-qt
[206/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[207/521] Test Bitcoin utilities...
[208/521] pow: testing aserti32d_tests
[209/521] Running utility command for check-pow-aserti32d_tests
[210/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o
[211/521] Running pow test suite
PASSED: pow test suite
[212/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[213/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[214/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[215/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[216/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[217/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[218/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[219/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[220/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[221/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[222/521] Linking CXX executable src/seeder/test/test-seeder
[223/521] seeder: testing options_tests
[224/521] seeder: testing db_tests
[225/521] seeder: testing message_writer_tests
[226/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[227/521] Running utility command for check-seeder-options_tests
[228/521] Running utility command for check-seeder-db_tests
[229/521] Running utility command for check-seeder-message_writer_tests
[230/521] seeder: testing parse_name_tests
[231/521] seeder: testing p2p_messaging_tests
[232/521] Running utility command for check-seeder-parse_name_tests
[233/521] Running utility command for check-seeder-p2p_messaging_tests
[234/521] seeder: testing write_name_tests
[235/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[236/521] Running utility command for check-seeder-write_name_tests
[237/521] Running seeder test suite
PASSED: seeder test suite
[238/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[239/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[240/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[241/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[242/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[243/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[244/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[245/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[246/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[247/521] Linking CXX executable src/qt/test/test_bitcoin-qt
[248/521] bitcoin-qt: testing test_bitcoin-qt
[249/521] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[0m[1;30mchronik_block_info.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_chronik_info.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_cors.py                            | ○ Skipped | 0 s
[0m[1;30mchronik_disable_token_index.py             | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_electrum_basic.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_electrum_blockchain.py             | ○ Skipped | 0 s
[0m[1;30mchronik_lokad_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_conflicts.py               | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
[0m[1;30mchronik_pause.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_plugin_groups.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_plugins.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_plugins_setup.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py            | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_scripthash.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                        | ○ Skipped | 0 s
[0m[1;30mchronik_token_alp.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_token_broadcast_txs.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_burn.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_token_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_token_parse_failure.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_script_group.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_fungible.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_nft1.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_tx_removal_order.py                | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                              | ○ Skipped | 1 s
[0m[1;30mchronik_ws_ordering.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ping.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                       | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_discover.py              | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_externalip.py            | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py                | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py               | ○ Skipped | 0 s
[0m[1m
ALL                                        | ✓ Passed  | 2589 s (accumulated) 
[0mRuntime: 217 s

[242/529] Running pow test suite
PASSED: pow test suite
[251/529] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[253/529] Running secp256k1 test suite
PASSED: secp256k1 test suite
[256/529] Running avalanche test suite
PASSED: avalanche test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

tests/test_iguana.py::test_invalid_inputindex ##teamcity[testStarted timestamp='2025-06-19T13:59:26.599' captureStandardOutput='false' flowId='tests.test_iguana.test_invalid_inputindex' metainfo='test_invalid_inputindex' name='tests.test_iguana.test_invalid_inputindex']
PASSED                     [ 25%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.614' duration='14' flowId='tests.test_iguana.test_invalid_inputindex' name='tests.test_iguana.test_invalid_inputindex']

tests/test_iguana.py::test_sig_push_only ##teamcity[testStarted timestamp='2025-06-19T13:59:26.614' captureStandardOutput='false' flowId='tests.test_iguana.test_sig_push_only' metainfo='test_sig_push_only' name='tests.test_iguana.test_sig_push_only']
PASSED                          [ 30%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.680' duration='64' flowId='tests.test_iguana.test_sig_push_only' name='tests.test_iguana.test_sig_push_only']

tests/test_iguana.py::test_script_sig_success ##teamcity[testStarted timestamp='2025-06-19T13:59:26.681' captureStandardOutput='false' flowId='tests.test_iguana.test_script_sig_success' metainfo='test_script_sig_success' name='tests.test_iguana.test_script_sig_success']
PASSED                     [ 35%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.752' duration='70' flowId='tests.test_iguana.test_script_sig_success' name='tests.test_iguana.test_script_sig_success']

tests/test_iguana.py::test_script_sig_invalid_opcode_encoding ##teamcity[testStarted timestamp='2025-06-19T13:59:26.752' captureStandardOutput='false' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' metainfo='test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding']
PASSED     [ 40%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.824' duration='70' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding']

tests/test_iguana.py::test_script_pub_key_success ##teamcity[testStarted timestamp='2025-06-19T13:59:26.824' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_success' metainfo='test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success']
PASSED                 [ 45%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.908' duration='82' flowId='tests.test_iguana.test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success']

tests/test_iguana.py::test_script_pub_key_failure ##teamcity[testStarted timestamp='2025-06-19T13:59:26.908' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_failure' metainfo='test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure']
PASSED                 [ 50%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.944' duration='34' flowId='tests.test_iguana.test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure']

tests/test_iguana.py::test_script_pub_key_empty_stack ##teamcity[testStarted timestamp='2025-06-19T13:59:26.944' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_empty_stack' metainfo='test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack']
PASSED             [ 55%]##teamcity[testFinished timestamp='2025-06-19T13:59:26.980' duration='34' flowId='tests.test_iguana.test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack']

tests/test_iguana.py::test_script_pub_key_false_stack ##teamcity[testStarted timestamp='2025-06-19T13:59:26.980' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_false_stack' metainfo='test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack']
PASSED             [ 60%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.016' duration='35' flowId='tests.test_iguana.test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack']

tests/test_iguana.py::test_script_pub_key_cleanstack ##teamcity[testStarted timestamp='2025-06-19T13:59:27.017' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_cleanstack' metainfo='test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack']
PASSED              [ 65%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.050' duration='32' flowId='tests.test_iguana.test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack']

tests/test_iguana.py::test_redeem_script_success ##teamcity[testStarted timestamp='2025-06-19T13:59:27.050' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_success' metainfo='test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success']
PASSED                  [ 70%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.121' duration='69' flowId='tests.test_iguana.test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success']

tests/test_iguana.py::test_redeem_script_error ##teamcity[testStarted timestamp='2025-06-19T13:59:27.121' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_error' metainfo='test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error']
PASSED                    [ 75%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.157' duration='34' flowId='tests.test_iguana.test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error']

tests/test_iguana.py::test_redeem_script_exception ##teamcity[testStarted timestamp='2025-06-19T13:59:27.158' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_exception' metainfo='test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']
PASSED                [ 80%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.173' duration='14' flowId='tests.test_iguana.test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']

tests/test_iguana.py::test_redeem_script_empty_stack ##teamcity[testStarted timestamp='2025-06-19T13:59:27.173' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_empty_stack' metainfo='test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']
PASSED              [ 85%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.187' duration='13' flowId='tests.test_iguana.test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']

tests/test_iguana.py::test_redeem_script_false ##teamcity[testStarted timestamp='2025-06-19T13:59:27.188' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_false' metainfo='test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']
PASSED                    [ 90%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.202' duration='13' flowId='tests.test_iguana.test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']

tests/test_iguana.py::test_redeem_script_cleanstack ##teamcity[testStarted timestamp='2025-06-19T13:59:27.203' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_cleanstack' metainfo='test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']
PASSED               [ 95%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.217' duration='13' flowId='tests.test_iguana.test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']

tests/test_iguana.py::test_redeem_script_input_sigchecks ##teamcity[testStarted timestamp='2025-06-19T13:59:27.218' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' metainfo='test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']
PASSED          [100%]##teamcity[testFinished timestamp='2025-06-19T13:59:27.296' duration='77' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']


============================== 20 passed in 0.89s ==============================
[182/489] Running pow test suite
PASSED: pow test suite
[206/489] Running seeder test suite
PASSED: seeder test suite
[209/489] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[234/489] Running avalanche test suite
PASSED: avalanche test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_txn_clone.py --mineblock            | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                  | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock      | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli               | ✓ Passed  | 1 s
[0m[1;30mchronik_avalanche.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_block.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_block_header.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_block_info.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_chronik_info.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_cors.py                            | ○ Skipped | 0 s
[0m[1;30mchronik_disable_token_index.py             | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_electrum_basic.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_electrum_blockchain.py             | ○ Skipped | 0 s
[0m[1;30mchronik_lokad_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_conflicts.py               | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
[0m[1;30mchronik_pause.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_plugin_groups.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_plugins.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_plugins_setup.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py            | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_scripthash.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                        | ○ Skipped | 0 s
[0m[1;30mchronik_token_alp.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_token_broadcast_txs.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_burn.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_token_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_token_parse_failure.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_script_group.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_fungible.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_nft1.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_tx_removal_order.py                | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ordering.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ping.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                       | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_discover.py              | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_externalip.py            | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py                | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py               | ○ Skipped | 0 s
[0m[1m
ALL                                        | ✓ Passed  | 1214 s (accumulated) 
[0mRuntime: 102 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

unbreak unit test

Harbormaster completed remote builds in B33669: Diff 54545.Jun 19 2025, 19:41

Fabien accepted this revision.Jun 20 2025, 08:05

This revision is now accepted and ready to land.Jun 20 2025, 08:05

Closed by commit rABC59844d444b37: logging: Replace uses of LogPrintfCategory (authored by PiRK). · Explain WhyJun 20 2025, 08:42

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC59844d444b37: logging: Replace uses of LogPrintfCategory.