Differential D18878
[validation] Add detailed txin/txout information for script error messages Authored by PiRK on Wed, Nov 5, 14:22.
Details
Don't just report which script error occurred, but which in which input of which transaction, This is a partial backport of core#31112 Also revert a temporary hack in checkqueue.h that was needed to work around a GCC 12 bug. Depends on D18877 ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: PASSED [ 40%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.072' duration='43' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding'] tests/test_iguana.py::test_script_pub_key_success ##teamcity[testStarted timestamp='2025-11-05T14:53:49.073' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_success' metainfo='test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success'] PASSED [ 45%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.137' duration='63' flowId='tests.test_iguana.test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success'] tests/test_iguana.py::test_script_pub_key_failure ##teamcity[testStarted timestamp='2025-11-05T14:53:49.138' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_failure' metainfo='test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure'] PASSED [ 50%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.159' duration='20' flowId='tests.test_iguana.test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure'] tests/test_iguana.py::test_script_pub_key_empty_stack ##teamcity[testStarted timestamp='2025-11-05T14:53:49.160' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_empty_stack' metainfo='test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack'] PASSED [ 55%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.184' duration='23' flowId='tests.test_iguana.test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack'] tests/test_iguana.py::test_script_pub_key_false_stack ##teamcity[testStarted timestamp='2025-11-05T14:53:49.184' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_false_stack' metainfo='test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack'] PASSED [ 60%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.207' duration='21' flowId='tests.test_iguana.test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack'] tests/test_iguana.py::test_script_pub_key_cleanstack ##teamcity[testStarted timestamp='2025-11-05T14:53:49.208' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_cleanstack' metainfo='test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack'] PASSED [ 65%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.227' duration='19' flowId='tests.test_iguana.test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack'] tests/test_iguana.py::test_redeem_script_success ##teamcity[testStarted timestamp='2025-11-05T14:53:49.228' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_success' metainfo='test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success'] PASSED [ 70%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.277' duration='49' flowId='tests.test_iguana.test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success'] tests/test_iguana.py::test_redeem_script_error ##teamcity[testStarted timestamp='2025-11-05T14:53:49.278' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_error' metainfo='test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error'] PASSED [ 75%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.290' duration='11' flowId='tests.test_iguana.test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error'] tests/test_iguana.py::test_redeem_script_exception ##teamcity[testStarted timestamp='2025-11-05T14:53:49.291' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_exception' metainfo='test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception'] PASSED [ 80%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.308' duration='16' flowId='tests.test_iguana.test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception'] tests/test_iguana.py::test_redeem_script_empty_stack ##teamcity[testStarted timestamp='2025-11-05T14:53:49.308' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_empty_stack' metainfo='test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack'] PASSED [ 85%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.321' duration='11' flowId='tests.test_iguana.test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack'] tests/test_iguana.py::test_redeem_script_false ##teamcity[testStarted timestamp='2025-11-05T14:53:49.321' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_false' metainfo='test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false'] PASSED [ 90%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.333' duration='11' flowId='tests.test_iguana.test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false'] tests/test_iguana.py::test_redeem_script_cleanstack ##teamcity[testStarted timestamp='2025-11-05T14:53:49.334' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_cleanstack' metainfo='test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack'] PASSED [ 95%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.346' duration='11' flowId='tests.test_iguana.test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack'] tests/test_iguana.py::test_redeem_script_input_sigchecks ##teamcity[testStarted timestamp='2025-11-05T14:53:49.346' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' metainfo='test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks'] PASSED [100%]##teamcity[testFinished timestamp='2025-11-05T14:53:49.380' duration='33' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks'] ============================== 20 passed in 0.68s ============================== [527/545] bitcoin: testing bridgeprimitives_tests [528/545] Test Bitcoin utilities... [529/545] Running utility command for check-bitcoin-bridgeprimitives_tests [530/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o [531/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o [532/545] bitcoin: testing scriptnum_63bit_tests [533/545] Running utility command for check-bitcoin-scriptnum_63bit_tests [534/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o [535/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o [536/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o [537/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o [538/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o [539/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o [540/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o [541/545] Linking CXX executable src/qt/test/test_bitcoin-qt [542/545] bitcoin-qt: testing test_bitcoin-qt [543/545] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1 Comment Actions revert the hack introduced in D18876. This seems to be no longer needed after local_result = check() assigns a std::optional<std::pair<R, std::string>> rather than a std::optional<R> in CCheckQueue::Loop |
