This is a partial backport of core#31112
https://github.com/bitcoin/bitcoin/pull/31112/commits/b49df703f031894b41ec1a624137e5d3206940b5
Depends on D18878
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC0ffeacec23f8: [validation] include all logged information in BlockValidationState
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/validation.cpp | ||
|---|---|---|
| 2339–2341 ↗ | (On Diff #56434) | The deduplication is done in the next diff |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log:
2025-11-05T15:00:43.548796Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/txmempool.cpp:404] [check] [mempool] Checking mempool with 1 transactions and 1 inputs 2025-11-05T15:00:43.548837Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/validationinterface.cpp:226] [operator()] [validation] TransactionAddedToMempool: txid=9456e31e45bd619e72ddb7897ad6f07a59998306c99c7fcc36b74ac509aefddf 2025-11-05T15:00:43.548934Z [/work/src/util/thread.cpp:20] [TraceThread] scheduler thread exit 2025-11-05T15:00:43.550640Z [/work/src/test/util/random.cpp:39] [Seed] Seed: Setting random seed for current tests to RANDOM_CTX_SEED=aa64c5ff703bf53a5da41e193e570684a3560395d6de22ef76dd2bf923510c33 2025-11-05T15:00:43.550673Z [/work/src/init/common.cpp:253] [LogPackageVersion] Bitcoin ABC version v0.32.2-3813ab3750c6 (release build) 2025-11-05T15:00:43.550864Z [/work/src/kernel/context.cpp:19] [Context] Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation 2025-11-05T15:00:43.550883Z [/work/src/random.cpp:106] [ReportHardwareRand] Using RdSeed as additional entropy source 2025-11-05T15:00:43.550896Z [/work/src/random.cpp:109] [ReportHardwareRand] Using RdRand as an additional entropy source *** 1 failure is detected in the test module "Bitcoin ABC unit tests" [499/545] bitcoin: testing transaction_tests [500/545] bitcoin: testing validation_block_tests [501/545] Linking CXX executable src/seeder/test/test-seeder [502/545] Running utility command for check-bitcoin-transaction_tests [503/545] Running utility command for check-bitcoin-validation_block_tests [504/545] seeder: testing db_tests [505/545] seeder: testing options_tests [506/545] Running utility command for check-seeder-db_tests [507/545] seeder: testing message_writer_tests [508/545] Running utility command for check-seeder-options_tests [509/545] Running utility command for check-seeder-message_writer_tests [510/545] seeder: testing p2p_messaging_tests [511/545] seeder: testing parse_name_tests [512/545] Running utility command for check-seeder-p2p_messaging_tests [513/545] Running utility command for check-seeder-parse_name_tests [514/545] seeder: testing write_name_tests [515/545] Running utility command for check-seeder-write_name_tests [516/545] Running seeder test suite PASSED: seeder test suite [517/545] pow: testing aserti32d_tests [518/545] Running utility command for check-pow-aserti32d_tests [519/545] Running pow test suite PASSED: pow test suite [520/545] bitcoin: testing validation_chainstatemanager_tests [521/545] Running utility command for check-bitcoin-validation_chainstatemanager_tests [522/545] bitcoin: testing wallet_tests [523/545] bitcoin: testing coinselector_tests [524/545] Running utility command for check-bitcoin-wallet_tests [525/545] Running utility command for check-bitcoin-coinselector_tests [526/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o [527/545] bitcoin: testing bridgeprimitives_tests [528/545] Running utility command for check-bitcoin-bridgeprimitives_tests [529/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o [530/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o [531/545] bitcoin: testing scriptnum_63bit_tests [532/545] Running utility command for check-bitcoin-scriptnum_63bit_tests [533/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o [534/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o [535/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o [536/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o [537/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o [538/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o [539/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o [540/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o [541/545] Linking CXX executable src/qt/test/test_bitcoin-qt [542/545] bitcoin-qt: testing test_bitcoin-qt [543/545] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1