Page MenuHomePhabricator
Differential D18880

[validation] merge all ConnectBlock debug logging code paths
ClosedPublic
Actions

Authored by PiRK on Wed, Nov 5, 14:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4ddd97b95f02: [validation] merge all ConnectBlock debug logging code paths
Summary

This concludes backport of core#31112
https://github.com/bitcoin/bitcoin/pull/31112/commits/492e1f09943fcb6145c21d470299305a19e17d8b
Depends on D18879

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Nov 5, 14:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 5, 14:29
PiRK requested review of this revision.Wed, Nov 5, 14:29
teamcity edited the summary of this revision. (Show Details)Wed, Nov 5, 14:29
PiRK planned changes to this revision.Wed, Nov 5, 14:46
Harbormaster completed remote builds in B34964: Diff 56435.Wed, Nov 5, 15:10
teamcity added a comment.Wed, Nov 5, 15:10
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

2025-11-05T15:09:45.773163Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validationinterface.cpp:289] [NewPoWValidBlock] [validation] NewPoWValidBlock: block hash=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97
2025-11-05T15:09:45.773306Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:3002] [ConnectTip] [bench]   - Load block from disk: 0.00ms [0.00s]
2025-11-05T15:09:45.773332Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:2241] [ConnectBlock] [bench]     - Sanity checks: 0.00ms [0.00s (0.00ms/blk)]
2025-11-05T15:09:45.773350Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:2360] [ConnectBlock] [bench]     - Fork checks: 0.02ms [0.09s (0.04ms/blk)]
2025-11-05T15:09:45.773367Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:2502] [ConnectBlock] [bench]       - Connect 1 transactions: 0.02ms (0.016ms/tx, 0.000ms/txin) [0.05s (0.02ms/blk)]
2025-11-05T15:09:45.773384Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:2536] [ConnectBlock] [bench]     - Verify 0 txins: 0.03ms (0.000ms/txin) [0.12s (0.05ms/blk)]
2025-11-05T15:09:45.773428Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:2558] [ConnectBlock] [bench]     - Index writing: 0.04ms [0.06s (0.03ms/blk)]
2025-11-05T15:09:45.773444Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validationinterface.cpp:281] [BlockChecked] [validation] BlockChecked: block hash=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97 state=Valid
2025-11-05T15:09:45.773467Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:3101] [ConnectTip] [bench]   - Connect total: 0.16ms [0.24s (0.10ms/blk)]
2025-11-05T15:09:45.773491Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:3110] [ConnectTip] [bench]   - Flush: 0.02ms [0.03s (0.01ms/blk)]
2025-11-05T15:09:45.773506Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:3122] [ConnectTip] [bench]   - Writing chainstate: 0.02ms [0.02s (0.01ms/blk)]
2025-11-05T15:09:45.773528Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:2824] [UpdateTipLog] UpdateTip: new best=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97 height=201 version=0x20000000 log2_work=8.658211 tx=202 date='2020-08-31T15:35:51Z' progress=1.000000 cache=0.3MiB(201txo)
2025-11-05T15:09:45.773543Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:3151] [ConnectTip] [bench]   - Connect postprocess: 0.04ms [0.05s (0.02ms/blk)]
2025-11-05T15:09:45.773557Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validation.cpp:3154] [ConnectTip] [bench] - Connect block: 0.24ms [0.35s (0.14ms/blk)]
2025-11-05T15:09:45.773573Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validationinterface.cpp:252] [BlockConnected] [validation] Enqueuing BlockConnected: block hash=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97 block height=201
2025-11-05T15:09:45.773597Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/txmempool.cpp:404] [check] [mempool] Checking mempool with 0 transactions and 0 inputs
2025-11-05T15:09:45.773645Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validationinterface.cpp:252] [operator()] [validation] BlockConnected: block hash=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97 block height=201
2025-11-05T15:09:45.773735Z (mocktime: 2020-08-31T15:35:51Z) [/work/src/validationinterface.cpp:212] [UpdatedBlockTip] [validation] Enqueuing UpdatedBlockTip: new block hash=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97 fork block hash=64a1a2851547be59a99d197e326eb9d8dbc282c4a0d152c9ee378c59891a52ff (in IBD=false)
2025-11-05T15:09:45.773808Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/validationinterface.cpp:212] [operator()] [validation] UpdatedBlockTip: new block hash=6689ada58c7d69f9d1087db6aa15821de8ddad17d7e4ab07aa41020bd1c12d97 fork block hash=64a1a2851547be59a99d197e326eb9d8dbc282c4a0d152c9ee378c59891a52ff (in IBD=false)
2025-11-05T15:09:45.773851Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/txmempool.cpp:404] [check] [mempool] Checking mempool with 0 transactions and 0 inputs
/work/chronik/test/chronikbridge_tests.cpp(325): error: in "chronikbridge_tests/test_bridge_broadcast_tx": check ex.what() == "Transaction rejected by mempool: " "mandatory-script-verify-flag-failed (Operation " "not valid with the current stack size)" has failed [Transaction rejected by mempool: mandatory-script-verify-flag-failed (Operation not valid with the current stack size), input 0 of 34e4337bd38a08a63ee184f2b3032489a8fbb9040bf0efc334f8eea754bd1a3b, spending 87625fca1709405b1b33930bb5548538d459d54cfee5e261153459d0dd272401:0 != Transaction rejected by mempool: mandatory-script-verify-flag-failed (Operation not valid with the current stack size)]
2025-11-05T15:09:45.773983Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/txmempool.cpp:404] [check] [mempool] Checking mempool with 0 transactions and 0 inputs
2025-11-05T15:09:45.774066Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/txmempool.cpp:404] [check] [mempool] Checking mempool with 0 transactions and 0 inputs
2025-11-05T15:09:45.774125Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/validationinterface.cpp:226] [TransactionAddedToMempool] [validation] Enqueuing TransactionAddedToMempool: txid=9456e31e45bd619e72ddb7897ad6f07a59998306c99c7fcc36b74ac509aefddf
2025-11-05T15:09:45.774153Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/txmempool.cpp:404] [check] [mempool] Checking mempool with 1 transactions and 1 inputs
2025-11-05T15:09:45.774198Z (mocktime: 2020-08-31T15:35:52Z) [/work/src/validationinterface.cpp:226] [operator()] [validation] TransactionAddedToMempool: txid=9456e31e45bd619e72ddb7897ad6f07a59998306c99c7fcc36b74ac509aefddf
2025-11-05T15:09:45.774255Z [/work/src/util/thread.cpp:20] [TraceThread] scheduler thread exit
2025-11-05T15:09:45.775695Z [/work/src/test/util/random.cpp:39] [Seed] Seed: Setting random seed for current tests to RANDOM_CTX_SEED=695efb43685678e2c24c1dd8257c33eeecd1e051ef513fe2dbad72ca9a74c8c4
2025-11-05T15:09:45.775721Z [/work/src/init/common.cpp:253] [LogPackageVersion] Bitcoin ABC version v0.32.2-2ca727002721 (release build)
2025-11-05T15:09:45.775881Z [/work/src/kernel/context.cpp:19] [Context] Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2025-11-05T15:09:45.775896Z [/work/src/random.cpp:106] [ReportHardwareRand] Using RdSeed as additional entropy source
2025-11-05T15:09:45.775907Z [/work/src/random.cpp:109] [ReportHardwareRand] Using RdRand as an additional entropy source

*** 1 failure is detected in the test module "Bitcoin ABC unit tests"
[522/545] bitcoin: testing transaction_tests
[523/545] pow: testing grasberg_tests
[524/545] Running utility command for check-pow-grasberg_tests
[525/545] Running utility command for check-bitcoin-transaction_tests
[526/545] bitcoin: testing wallet_tests
[527/545] Running utility command for check-bitcoin-wallet_tests
[528/545] pow: testing aserti32d_tests
[529/545] Running utility command for check-pow-aserti32d_tests
[530/545] Running pow test suite
PASSED: pow test suite
[531/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[532/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[533/545] bitcoin: testing coinselector_tests
[534/545] Running utility command for check-bitcoin-coinselector_tests
[535/545] bitcoin: testing bridgeprimitives_tests
[536/545] Running utility command for check-bitcoin-bridgeprimitives_tests
[537/545] bitcoin: testing scriptnum_63bit_tests
[538/545] Running utility command for check-bitcoin-scriptnum_63bit_tests
[539/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[540/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[541/545] Linking CXX executable src/qt/test/test_bitcoin-qt
[542/545] bitcoin-qt: testing test_bitcoin-qt
[543/545] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 56439.Wed, Nov 5, 15:49

rebase

Harbormaster completed remote builds in B34968: Diff 56439.Wed, Nov 5, 16:22
Fabien accepted this revision.Wed, Nov 5, 16:49
This revision is now accepted and ready to land.Wed, Nov 5, 16:49
PiRK updated this revision to Diff 56459.Wed, Nov 5, 19:32

rebase

PiRK added a comment.Wed, Nov 5, 19:33

@bot build-chronik chronik-client-integration-tests

teamcity awarded a token.Wed, Nov 5, 19:33
Harbormaster completed remote builds in B34984: Diff 56459.Wed, Nov 5, 20:06
Closed by commit rABC4ddd97b95f02: [validation] merge all ConnectBlock debug logging code paths (authored by PiRK). · Explain WhyWed, Nov 5, 20:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4ddd97b95f02: [validation] merge all ConnectBlock debug logging code paths.

Revision Contents
Changeset List

PathSize
src/
54 lines

Diff 56470

View Options

src/validation.cpp

Loading...