Differential D1893

Various nits in netbase.cpp
ClosedPublic
Actions

Authored by deadalnix on Oct 7 2018, 23:45.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGde5b9f260490: Various nits in netbase.cpp
rABCde5b9f260490: Various nits in netbase.cpp

Summary

As per title

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 7 2018, 23:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2018, 23:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3533: Diff 5311.Oct 8 2018, 00:04

jasonbcox accepted this revision.Oct 8 2018, 17:50

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/seeder/main.cpp
488 ↗	(On Diff #5311)	Scary that this actually worked before. Is there a compiler option to warn for this kind of promotion-style implicit conversion?

This revision is now accepted and ready to land.Oct 8 2018, 17:50

deadalnix marked an inline comment as done.Oct 8 2018, 18:52

deadalnix added inline comments.

src/seeder/main.cpp
488 ↗	(On Diff #5311)	No, but we can have a linter to yell at you when you don't declare a constructor explicit.

Closed by commit rABCde5b9f260490: Various nits in netbase.cpp (authored by deadalnix). · Explain WhyOct 8 2018, 18:54

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D4727: Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency.Dec 13 2019, 22:41

Revision Contents
Changeset List

Path

Size

src/

3 lines

20 lines

seeder/

6 lines

Diff 5313

src/netbase.h

Loading...

src/netbase.cpp

Loading...

src/seeder/main.cpp

Loading...