Page MenuHomePhabricator
Differential D19034

crypto: refactor ChaCha20 classes to use Span<std::byte> interface
ClosedPublic
Actions

Authored by PiRK on Wed, Dec 3, 14:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC54538f391d93: crypto: refactor ChaCha20 classes to use Span<std::byte> interface
Summary

This is a partial backport of core#28100
https://github.com/bitcoin/bitcoin/pull/28100/commits/3da636e08b781fa2f7c1c23bb937015185732a75

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Wed, Dec 3, 14:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Dec 3, 14:13
PiRK requested review of this revision.Wed, Dec 3, 14:13
teamcity edited the summary of this revision. (Show Details)Wed, Dec 3, 14:13
PiRK added a child revision: D19035: random: simplify FastRandomContext::randbytes using fillrand.Wed, Dec 3, 14:16
Harbormaster completed remote builds in B35210: Diff 56842.Wed, Dec 3, 14:32
Fabien requested changes to this revision.Thu, Dec 4, 08:31
Fabien added a subscriber: Fabien.

More a question than requesting change

src/crypto/chacha20.cpp
47 ↗(On Diff #56842)

see related question in the header

src/crypto/chacha20.h
100 ↗(On Diff #56842)

Here and below

101 ↗(On Diff #56842)

I wonder if the size be enforced at compile time like so

src/crypto/chacha20poly1305.cpp
20 ↗(On Diff #56842)

same here

This revision now requires changes to proceed.Thu, Dec 4, 08:31
PiRK requested review of this revision.Thu, Dec 4, 10:05

We can probably do that after we switch from Span to std::span. The Span template does not have the Extent parameter

PiRK updated this revision to Diff 56854.Thu, Dec 4, 10:10

add a TODO comment regarding compile time enforcement of KEYLEN

PiRK updated this revision to Diff 56855.Thu, Dec 4, 10:13

add another comment about the same in SetKey

Harbormaster completed remote builds in B35221: Diff 56854.Thu, Dec 4, 10:29
Harbormaster completed remote builds in B35222: Diff 56855.Thu, Dec 4, 10:32
PiRK mentioned this in D19045: addrman: tidy up unit tests.Thu, Dec 4, 10:43
Fabien requested changes to this revision.Thu, Dec 4, 11:47
Fabien added inline comments.
src/crypto/chacha20.cpp
48 ↗(On Diff #56855)

This comment should be before the assert

src/crypto/chacha20.h
100 ↗(On Diff #56855)
106 ↗(On Diff #56855)
This revision now requires changes to proceed.Thu, Dec 4, 11:47
PiRK updated this revision to Diff 56858.Thu, Dec 4, 12:07

fix 3 comments as suggested

Harbormaster completed remote builds in B35224: Diff 56858.Thu, Dec 4, 12:50
Fabien accepted this revision.Thu, Dec 4, 14:18
This revision is now accepted and ready to land.Thu, Dec 4, 14:18
Closed by commit rABC54538f391d93: crypto: refactor ChaCha20 classes to use Span<std::byte> interface (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyThu, Dec 4, 15:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC54538f391d93: crypto: refactor ChaCha20 classes to use Span<std::byte> interface.

Revision Contents
Changeset List

PathSize
src/
bench/
13 lines
crypto/
82 lines
132 lines
34 lines
4 lines
6 lines
15 lines
test/
72 lines
fuzz/
43 lines

Diff 56854

View Options

src/bench/chacha20.cpp

Loading...
View Options

src/crypto/chacha20.h

Loading...
View Options

src/crypto/chacha20.cpp

Loading...
View Options

src/crypto/chacha20poly1305.cpp

Loading...
View Options

src/crypto/muhash.cpp

Loading...
View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...
View Options

src/test/crypto_tests.cpp

Loading...
View Options

src/test/fuzz/crypto_chacha20.cpp

Loading...