Page MenuHomePhabricator
Differential D19036

crypto: require key on ChaCha20 initialization
ClosedPublic
Actions

Authored by PiRK on Wed, Dec 3, 14:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC369ce361944b: crypto: require key on ChaCha20 initialization
Summary

This is a partial backport of core#28100
https://github.com/bitcoin/bitcoin/pull/28100/commits/7d1cd932342e74421ae927800eeada14f504b944
Depends on D19035

Test Plan

ninja all check bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Dec 3, 14:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Dec 3, 14:17
PiRK requested review of this revision.Wed, Dec 3, 14:17
teamcity edited the summary of this revision. (Show Details)Wed, Dec 3, 14:17
PiRK added a child revision: D19037: fuzz: support std::byte in Consume{Fixed,Variable}LengthByteVector.Wed, Dec 3, 14:19
Harbormaster completed remote builds in B35212: Diff 56844.Wed, Dec 3, 14:46
Fabien accepted this revision.Thu, Dec 4, 08:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/crypto/chacha20.h
43 ↗(On Diff #56844)

just noticed now but it might require an explicit keyword

This revision is now accepted and ready to land.Thu, Dec 4, 08:35
Closed by commit rABC369ce361944b: crypto: require key on ChaCha20 initialization (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyThu, Dec 4, 15:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC369ce361944b: crypto: require key on ChaCha20 initialization.

Revision Contents
Changeset List

PathSize
src/
crypto/
6 lines
4 lines
17 lines
test/
fuzz/
10 lines

Diff 56869

View Options

src/crypto/chacha20.h

Loading...
View Options

src/crypto/chacha20.cpp

Loading...
View Options

src/random.cpp

Loading...
View Options

src/test/fuzz/crypto_chacha20.cpp

Loading...