Page MenuHomePhabricator

Format guiutil.h and guiutil.cpp
ClosedPublic

Authored by freetrader on Jun 13 2017, 21:42.

Details

Summary

Pre-cleanup for D191.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJun 13 2017, 21:42
deadalnix requested changes to this revision.Jun 13 2017, 21:59

There is some babysitting to do on that one.

src/qt/guiutil.cpp
209 ↗(On Diff #445)

dito

288 ↗(On Diff #445)

Put comment before the if.

583 ↗(On Diff #445)

Move coment before the if, it avoids doing this kind of thing.

938 ↗(On Diff #445)

Put comment before the variable declaration.

src/qt/guiutil.h
136 ↗(On Diff #445)

This comment is fucked up. You can just put in on one line and let arc lint do its job :)

160 ↗(On Diff #445)

Same here.

231 ↗(On Diff #445)

dito

245 ↗(On Diff #445)

dito

This revision now requires changes to proceed.Jun 13 2017, 21:59
freetrader edited edge metadata.

Fixes from review

Still a few fubared comments but let's go.

This revision is now accepted and ready to land.Jun 13 2017, 22:38
This revision was automatically updated to reflect the committed changes.