Page MenuHomePhabricator
Differential D1954

Fix spurious addrman test failure
ClosedPublic
Actions

Authored by Fabien on Oct 21 2018, 13:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc58c4508f2aa: Fix spurious addrman test failure
rABCc58c4508f2aa: Fix spurious addrman test failure
Summary

Depends on D1955
Backport of core PR 10429

Test Plan
./src/test/test_bitcoin -t addrman_tests

Diff Detail

Event Timeline

Fabien created this revision.Oct 21 2018, 13:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 13:02
deadalnix requested changes to this revision.Oct 21 2018, 13:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/addrman_tests.cpp
114 ↗(On Diff #5479)

Fix the layout of the comment.

This revision now requires changes to proceed.Oct 21 2018, 13:04
teamcity added a subscriber: teamcity.Oct 21 2018, 13:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 13:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3641: Diff 5479.Oct 21 2018, 13:17
Fabien updated this revision to Diff 5480.Oct 21 2018, 13:24

Fix comments layout

teamcity added a comment.Oct 21 2018, 13:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 13:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3642: Diff 5480.Oct 21 2018, 13:34
deadalnix requested changes to this revision.Oct 21 2018, 13:39
deadalnix added inline comments.
src/test/addrman_tests.cpp
110 ↗(On Diff #5480)

If there are tests cases missing from upstream, please backport them instead of renumbering it all (which will make everything harder to backport.

114 ↗(On Diff #5480)

I mean the extra spaces.

This revision now requires changes to proceed.Oct 21 2018, 13:39
Fabien marked an inline comment as done.Oct 21 2018, 13:47
Fabien added inline comments.
src/test/addrman_tests.cpp
110 ↗(On Diff #5480)

There is none, core removed test numbering. Would you like me to also remove then ?

Fabien updated this revision to Diff 5481.Oct 21 2018, 13:49

Removed extra leading space in comments

teamcity added a comment.Oct 21 2018, 13:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 13:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3643: Diff 5481.Oct 21 2018, 13:59
Fabien updated this revision to Diff 5482.Oct 21 2018, 16:45

Avoid refactoring comments when doing a backport

teamcity added a comment.Oct 21 2018, 16:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 16:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3644: Diff 5482.Oct 21 2018, 16:55
Fabien updated this revision to Diff 5485.Oct 21 2018, 17:34

Rebase to clean the stack

Fabien edited the summary of this revision. (Show Details)Oct 21 2018, 17:36
Fabien added a parent revision: D1955: Clean up addrman_tests.cpp.
teamcity added a comment.Oct 21 2018, 17:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 17:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3647: Diff 5485.Oct 21 2018, 17:45
deadalnix requested changes to this revision.Oct 21 2018, 19:23
deadalnix added inline comments.
src/test/addrman_tests.cpp
114 ↗(On Diff #5485)

This change was part of that PR. There is still something that isn't right.

This revision now requires changes to proceed.Oct 21 2018, 19:23
Fabien updated this revision to Diff 5491.Oct 21 2018, 19:46

Clean stack

teamcity added a comment.Oct 21 2018, 19:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Oct 21 2018, 19:53
This revision is now accepted and ready to land.Oct 21 2018, 19:53
teamcity added a comment.Oct 21 2018, 19:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3653: Diff 5491.Oct 21 2018, 19:56
Closed by commit rABCc58c4508f2aa: Fix spurious addrman test failure (authored by Fabien). · Explain WhyOct 22 2018, 13:23
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D1953: Add Clang thread safety annotations for variables guarded by CAddrMan.cs.Oct 23 2018, 13:49

Revision Contents
Changeset List

PathSize
src/
test/
31 lines

Diff 5482

View Options

src/test/addrman_tests.cpp

Loading...