Page MenuHomePhabricator

Fixed tx padding in rawtransactions.py
ClosedPublic

Authored by jasonbcox on Oct 22 2018, 22:10.

Details

Summary

Fixes tx padding in rawtransactions.py post-fork

Continues T418

Co-authored-by: Dagur Valberg Johannsson <dagurval@pvv.ntnu.no>

Test Plan

Apply this patch:

diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py
index dfa65aaad..7561b9979 100644
--- a/test/functional/test_framework/util.py
+++ b/test/functional/test_framework/util.py
@@ -336,6 +336,7 @@ def initialize_datadir(dirname, n):
         f.write("rpcport=" + str(rpc_port(n)) + "\n")
         f.write("listenonion=0\n")
         f.write("usecashaddr=1\n")
+        f.write("magneticanomalyactivationtime=1\n")
     return datadir

Then run the test:
./test_runner.py rawtransactions
Running the test fails without the fix and passes with it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pad-rawtx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3663
Build 5401: Bitcoin ABC Buildbot (legacy)
Build 5400: arc lint + arc unit