Page MenuHomePhabricator
Differential D1963

[Qt] Use wallet 0 in rpc console if running with multiple wallets
ClosedPublic
Actions

Authored by jasonbcox on Oct 23 2018, 22:30.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGb514f80c2ee8: [Qt] Use wallet 0 in rpc console if running with multiple wallets
rABCb514f80c2ee8: [Qt] Use wallet 0 in rpc console if running with multiple wallets
Summary

Backport of Core PR10870

Completes T441

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3669
Build 5413: Bitcoin ABC Buildbot (legacy)
Build 5412: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 23 2018, 22:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2018, 22:30
teamcity added a subscriber: teamcity.Oct 23 2018, 22:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Oct 23 2018, 22:31
teamcity added a comment.Oct 23 2018, 22:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3669: Diff 5518.Oct 23 2018, 22:38
deadalnix requested changes to this revision.Oct 24 2018, 23:20

Please edit description. Except that, LGTM.

likestamp

This revision now requires changes to proceed.Oct 24 2018, 23:20
deadalnix mentioned this in D1964: Replace save|restoreWindowGeometry with Qt functions.Oct 24 2018, 23:23
deadalnix mentioned this in D1965: [Qt] Don't add arguments of sensitive command to console window.
deadalnix mentioned this in D1966: Make tabs toolbar no longer have a context menu.Oct 24 2018, 23:26
jasonbcox requested review of this revision.Oct 25 2018, 00:58
jasonbcox edited the summary of this revision. (Show Details)
schancel accepted this revision.Oct 25 2018, 20:31
deadalnix accepted this revision.Oct 25 2018, 21:59
This revision is now accepted and ready to land.Oct 25 2018, 21:59
Closed by commit rABCb514f80c2ee8: [Qt] Use wallet 0 in rpc console if running with multiple wallets (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyOct 25 2018, 22:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
19 lines

Diff 5518

View Options

src/qt/rpcconsole.cpp

Loading...